fix: preserve grouped domains on fluent routes - #692
Open
elpete wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
domainsupplied bygroup()when starting a fluent route definitionThis is a follow-up to #690. That PR preserved domains during nested route resolution; this fixes the earlier registration step where
route()processed the grouped domain but discarded it beforeaddRoute().Verification
RouterTest: 67 passed, 0 failed, 0 errors on BoxLang 1.17.0+58RouterTest.cfcpassedgit diff --checkpassedNote: as recorded on #690, the newer local cfformat version disagrees with CI about an unchanged alignment line in
Router.cfc; that unrelated line remains byte-identical todevelopment.