Skip to content

Remove unused dependencies and narrow Tokio features - #1154

Closed
isPANN wants to merge 1 commit into
mainfrom
chore/trim-unused-dependencies
Closed

isPANN wants to merge 1 commit into
mainfrom
chore/trim-unused-dependencies

Conversation

@isPANN

@isPANN isPANN commented Sep 17, 2026

Copy link
Copy Markdown
Collaborator

Summary

Remove unused direct dependencies on ordered-float and tracing. Keep tracing-subscriber for MCP logging and let rmcp declare its own tracing dependency.

Narrow the direct Tokio features from full to rt-multi-thread, which supports the CLI runtime constructor. The existing rmcp transport-io feature supplies the required stdio support.

Only two manifests change. Dependency version requirements, Rust APIs, solver behavior, and website files are unchanged.

Validation

  • cargo test --workspace --all-features --lib --bins --tests: 6,478 passed, 2 existing ignored tests; includes MCP integration tests.
  • Checked source references and the all-features Tokio dependency tree.
  • git diff --check passed.
  • No executable source changes or new coverage-bearing lines.

@codecov

codecov Bot commented Sep 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.93%. Comparing base (7dd5fcd) to head (62e4d30).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1154   +/-   ##
=======================================
  Coverage   95.93%   95.93%           
=======================================
  Files        1074     1074           
  Lines      132106   132106           
=======================================
  Hits       126730   126730           
  Misses       5376     5376           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@isPANN

isPANN commented Sep 17, 2026

Copy link
Copy Markdown
Collaborator Author

Consolidated into #1163. The combined dependency versions, removals, feature selection, and workspace lint command pass all-feature workspace tests and Clippy.

@isPANN isPANN closed this Sep 17, 2026
@isPANN
isPANN deleted the chore/trim-unused-dependencies branch September 18, 2026 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant