Skip to content

simplify the package choice declaration #834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chris1111 wants to merge 1 commit into from
Closed

simplify the package choice declaration #834

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CloverPackage/package/Scripts.templates/CloverLogoutHook/preinstall
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ DEST_VOL="${3}"
EFI_ROOT_DIR=$(cd "${DEST_VOL}"/Private/tmp/EFIROOTDIR; pwd -P)
CLOVER_INSTALLER_PLIST_NEW="${DEST_VOL}@CLOVER_INSTALLER_PLIST_NEW@"
install_log="${DEST_VOL}/Private/tmp/Clover_Install_Log.txt"
installer_choice="@INSTALLER_CHOICE@"
installer_choice="org.clover.cloverlogouthook"

@chris1111 chris1111 Sep 2, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So you have to correct all the po file because it will indicated on top of com.projectosx.clover.installer.plist @INSTALLER_CHOICE@ my commits is a temporary commmits while waiting for slice to adjust all the files po


echo "====================================================="
echo " "
Expand Down
4 changes: 2 additions & 2 deletions CloverPackage/package/buildpkg.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1258,8 +1258,8 @@ fi
addTemplateScripts --pkg-rootdir="${PKG_BUILD_DIR}/${choiceId}" ${choiceId}
packageRefId=$(getPackageRefId "${packagesidentity}" "${choiceId}")
buildpackage "$packageRefId" "${choiceId}" "${PKG_BUILD_DIR}/${choiceId}" "/"
addChoice --start-visible="true" --title="CloverLogoutHook" --description="CloverLogoutHook for Clover Legacy Boot" --start-selected="false" --pkg-refs="$packageRefId" "${choiceId}"

addChoice --start-visible="true" --start-selected="false" \
--pkg-refs="$packageRefId" "${choiceId}"
# End build CloverLogoutHook package

# build rc scripts package
Expand Down