Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NX-OS BGP tables can leave Metric and LocPrf blank. The shared EVPN/MVPN parser can then silently interpret Weight and AS-path values as other columns.
For example, a lab EVPN row with Weight
0and AS path65003 65002was parsed as metric0, localpref65003and weight65002with the AS path omitted.This change uses the table header to identify column boundaries and preserve blank numeric fields. It makes
localprefoptional in the shared schema and updates the five corresponding registry entries. The existing parsing behavior is retained for output without a table header.The shared implementation affects
ShowBgpL2vpnEvpn,ShowBgpIpMvpnandShowBgpIpMvpnRouteType.Validation:
folder_parsing_job.pyfor all three classes.ShowBgpL2vpnEvpnRouteTypegolden fixture passed.The EVPN fixture comes from lab output; the MVPN fixtures are synthetic coverage for the shared implementation.
make jsoncompleted successfully. The registry diff retains only the five relevant schema updates, excluding unrelated regeneration changes.