Skip to content

fix: add missing import for importance_scheduler - #66

Merged
Cipher208 merged 1 commit into
masterfrom
fix/importance-scheduler-import
Aug 7, 2026
Merged

fix: add missing import for importance_scheduler#66
Cipher208 merged 1 commit into
masterfrom
fix/importance-scheduler-import

Conversation

@Cipher208

@Cipher208 Cipher208 commented Aug 7, 2026

Copy link
Copy Markdown
Owner

The importance scheduler was being started in the lifespan but wasn't imported, causing a NameError on startup.

Summary by CodeRabbit

  • Bug Fixes
    • Enabled the scheduler to start and stop correctly during server lifecycle events.

@Cipher208
Cipher208 merged commit 60bb9b7 into master Aug 7, 2026
18 of 20 checks passed
@Cipher208
Cipher208 deleted the fix/importance-scheduler-import branch August 7, 2026 20:08
@github-actions github-actions Bot added the fix label Aug 7, 2026
@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: f2800506-acb5-455b-b701-52fa87069555

📥 Commits

Reviewing files that changed from the base of the PR and between 705e000 and f56f483.

📒 Files selected for processing (1)
  • mcp_server/server.py

Walkthrough

The server now imports importance_scheduler, enabling its existing lifecycle start and stop calls.

Changes

Scheduler lifecycle wiring

Layer / File(s) Summary
Import scheduler for lifecycle calls
mcp_server/server.py
The server imports importance_scheduler for background-task startup and shutdown.

Estimated code review effort: 1 (Trivial) | ~2 minutes

✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/importance-scheduler-import

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@greptile-apps

greptile-apps Bot commented Aug 7, 2026

Copy link
Copy Markdown

Greptile Summary

The PR imports the existing importance_scheduler singleton so the server’s startup and shutdown lifecycle references resolve correctly.

  • Adds the missing direct import in mcp_server/server.py.
  • Restores access to the scheduler’s existing start() and stop() interface.

Confidence Score: 5/5

The PR appears safe to merge, with no actionable defects identified in the added import.

The imported module exists, exports the expected singleton, has no incompatible circular dependency, and supplies the lifecycle methods already called by the server.

Important Files Changed

Filename Overview
mcp_server/server.py Adds the missing scheduler import; the target module and exported singleton exist, and no circular dependency or import-time incompatibility was identified.

Reviews (1): Last reviewed commit: "fix: add missing import for importance_s..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants