Skip to content

As a developer I want the pull_request closed type removed from ci.yml so CI deploy runs are not silently cancelled on PR merge #258

Description

@ChristopherRotnes

Summary

ci.yml lists closed in its pull_request.types, but both jobs skip on a closed event (validate has an explicit if guard, deploy needs validate). The problem: both the pull_request: closed event and the push-to-master event share the same concurrency group (CI-<workflow>-refs/heads/master). When a PR is merged, the closed event fires first, starts a CI run, then the push event fires and — because cancel-in-progress: true — cancels the already-running push/deploy job. The staging cleanup is handled separately by cleanup-staging.yml and does not need closed in ci.yml at all. Confirmed by the cancelled deploy run on PR #257 merge.

Priority

High

Acceptance criteria

  • closed removed from pull_request.types in ci.yml
  • Next PR merge produces a single CI run that completes successfully (no cancellation)
  • cleanup-staging.yml still fires and closes the staging environment on PR merge

Out of scope

  • Consolidating cleanup logic into ci.ymlcleanup-staging.yml handles this correctly already

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions