[pull] master from MusicPlayerDaemon:master - #114
Merged
Conversation
After removing optional sort and window clauses, sticker find expects either four arguments or an operator/value pair for a total of six. With five arguments, the current code reads a nonexistent sixth element and may crash the daemon. Reject all other argument counts before accessing the optional value.
Deleting the device description downloader from OnHeaders() frees the CurlResponseHandlerAdapter while DataReceived() still uses it. A UPnP server can trigger a use-after-free by returning a non-200 response with body data. Throw HttpStatusError so the adapter defers cleanup until OnError().
This fixes WildMidi 0.5.0 build failures because WildMidi doesn't find libm.a - it's not looking in the NDK sysroot. By setting these cmake variables, we tell cmake where to find everything. Add both NDK sysroot and our own install prefix to CMAKE_FIND_ROOT_PATH.
release v0.24.15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )