Move hardcoded Adventure Mode strings to language files - #11619
Open
churrufli wants to merge 10 commits into
Open
Move hardcoded Adventure Mode strings to language files#11619churrufli wants to merge 10 commits into
churrufli wants to merge 10 commits into
Conversation
Jetz72
reviewed
Aug 17, 2026
Comment on lines
+467
to
+481
| modeSummary.name = Forge.getLocalizer().getMessage("lblSummary"); | ||
|
|
||
| StringBuilder summaryText = new StringBuilder(); | ||
| switch (selectedMode) { | ||
| case Standard: | ||
| summaryText.append("Mode: Standard\n\nYour starting deck is built from 2-3 Jumpstart packs of twenty cards each.\n\n"); | ||
| summaryText.append(Forge.getLocalizer().getMessage("advModeStandardSummary")); | ||
| switch (selectedDifficulty.name) { | ||
| case "Easy": | ||
| summaryText.append("On your currently selected difficulty, Easy, you will receive three jumpstart packs of your chosen color."); | ||
| summaryText.append(Forge.getLocalizer().getMessage("advDiffEasyStandard")); | ||
| break; | ||
| case "Normal": | ||
| summaryText.append("On your currently selected difficulty, Normal, you will receive two jumpstart packs of your chosen color and one of an allied color."); | ||
| summaryText.append(Forge.getLocalizer().getMessage("advDiffNormalStandard")); | ||
| break; | ||
| case "Hard": | ||
| summaryText.append("On your currently selected difficulty, Hard, you will receive one jumpstart pack of your chosen color and one of an allied color."); | ||
| summaryText.append(Forge.getLocalizer().getMessage("advDiffHardStandard")); |
Contributor
There was a problem hiding this comment.
In long methods that need many localizer calls, I'd suggest calling Forge.getLocalizer() once and stashing it in a variable.
Contributor
Author
There was a problem hiding this comment.
Okay, I’ll take a look at it (next week, I’m on vacation right now). Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some UI strings were still hardcoded in Java. This moves them into the .properties files, following the same pattern used elsewhere in the module.
Added all keys to en-US.properties.
Added Spanish translations to es-ES.properties.
Added the English text as placeholders to the other 8 languages.
No behavior changes apart from the new Spanish translations.
This only covers strings that was hardcoded in Java. The larger amount of narrative text in res/adventure/ is a huge separate task.