fix(#749): Type 0 WARNING thold_log records $warning_emails instead of $alert_emails - #792
Open
bmfmancini wants to merge 2 commits into
Open
fix(#749): Type 0 WARNING thold_log records $warning_emails instead of $alert_emails#792bmfmancini wants to merge 2 commits into
bmfmancini wants to merge 2 commits into
Conversation
…lert emails The type 0 warning notification log entry was incorrectly recording $alert_emails and $alert_bcc_emails instead of $warning_emails and $warning_bcc_emails. The mail was correctly sent to the warning list, but the threshold history UI showed the wrong recipients for all type-0 warning notifications.
somethingwithproof
approved these changes
Aug 17, 2026
somethingwithproof
requested changes
Aug 17, 2026
somethingwithproof
left a comment
somethingwithproof
left a comment
Member
There was a problem hiding this comment.
The warning-recipient correction is valid, but this branch also carries the unrelated three-line #789 threshold_value fix. Please drop those hunks, add a Cacti-Composer/Pest assertion that the sent and logged warning/BCC recipients match, and add the CHANGELOG entry. The branch currently has no CI result, so the behavior is unverified.
Member
|
This open PR currently has no CI checks registered on its head, and maintainer edits are disabled. Please enable maintainer edits or update/rebase the branch so the current pinned-Cacti integration and Pest workflows can run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #749
The type 0 warning notification log entry in
thold_functions.phpwas incorrectly recording$alert_emailsand$alert_bcc_emailsinstead of$warning_emailsand$warning_bcc_emails.The mail was correctly sent to
$warning_emails, but thethold_logcall recorded the alert list. As a result, the threshold history UI showed the wrong recipients for all type-0 warning notifications.Changes
In the type 0 (WARNING)
thold_logcall (~line 2582):'emails'changed from$alert_emails→$warning_emails'bcc_emails'changed from$alert_bcc_emails→$warning_bcc_emailsTesting
thold_mailcall in this branch correctly uses$warning_emails/$warning_bcc_emails, so the log now matches the actual recipients.