feat: 컨테이너(신청) 하나만 삭제하는 관리자 엔드포인트 추가 - #504
Open
yoon6yo wants to merge 1 commit into
Open
Conversation
관리자 콘솔의 컨테이너 상세 삭제 버튼이 계정 전체 삭제
엔드포인트(deleteUbuntuAccount)를 호출하고 있었는데, 이 엔드포인트는
그 유저네임에 딸린 살아있는 신청을 전부 순회해서 지우도록 의도된
것이라, 한 사용자가 컨테이너를 여러 개 가진 경우 하나만 지우려 해도
매번 나머지까지 같이 삭제됐다.
DELETE /api/admin/requests/{requestId}를 추가해 요청 하나만 정리하고,
같은 사용자의 다른 살아있는 신청이 남아있으면 우분투 계정(UID/GID)은
회수하지 않도록 했다. FULFILLED가 아니거나 마이그레이션/승인 진행
중이면 409로 거부한다.
Fixes #502
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Warning Review limit reachedNext included review available in 59 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DELETE /api/admin/requests/{requestId}를 추가해 요청 하나만 정리하도록 했습니다.Test plan
AdminUserServiceTest전체 통과 (마지막 신청 삭제/다른 신청 남음/상태 거부/Pod 삭제 실패 케이스 포함)./gradlew test전체 스위트 통과Closes #502
🤖 Generated with Claude Code