Conversation
|
Failed to generate code suggestions for PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
Bug fix, Enhancement
Description
Add Suricata startup detection via pidfile and socket
Introduce socket path configuration in YAML and CLI
Replace process name check with pidfile-based detection
Update stdout handling to null for cleaner execution
Diagram Walkthrough
File Walkthrough
argument.rs
Add socket path CLI argumentsrc/argument.rs
path_to_socketCLI argument with-sand--path-to-socketflagsyaml.rs
Add socket path configuration supportsrc/yaml.rs
socketfield toSuriconfstructfind_socketmethod to parse socket path from YAMLsuricata.rs
Implement pidfile and socket-based Suricata startup detectionsrc/suricata.rs
PIDFILEconstant for Suricata pidfile pathdelete_pid_fileandset_pid_filefunctionscheck_process_name_for_suricata_mainwithget_suricata_pidandwait_on_suricata_startStdio::null()for cleaner executionREADME.md
Document socket path configurationREADME.md
socketfield description in configuration tablesuriconf.yaml
Add default socket path to configurationsrc/suriconf.yaml
socketfield with default path/var/run/suricata/suricata-command.socket