Conversation
Match VK-AS as a complete name and cover the MTS false positives with shell-based regression tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
VK-ASalternative inBLACK_NAMESalso matchesTVK-AS. This selects the MTS recordsAS43038 TVK-AS (MTS PJSC)andAS43720 TVK-AS (MTS OJSC)and includes their announced networks in the general blacklist, affecting residential subscribers.Match
VK-ASas a complete name using POSIX character classes. Add regression tests that exercise the shared configuration throughshandgrep -iE, covering the two MTS records, case-insensitive exact matches, name boundaries, and independent blacklist terms.Validation:
python -m unittest discover -s tests -v: all 7 tests pass, including 3 new tests with 14 cases.sh -n blacklists_updater_common.subrandgit diff --checkpass.Generated blacklists are left to the existing update workflow after merge. This PR fixes the generator; it does not immediately change the published lists. No subscriber IP addresses or connection logs are included.