Conversation
…to gtf-system-includes
gtfierro
marked this pull request as draft
May 28, 2026 18:22
This was referenced May 31, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #777
Summary
Domestic_Water_Heateras a subclass ofWater_HeaterStorage_Water_Heater→Gas_Storage_Water_Heater(Atmospheric_Gas_Water_Heater,Power_Vent_Gas_Water_Heater),Electric_Storage_Water_Heater,Heat_Pump_Water_Heater,Solar_Water_HeaterTankless_Water_Heater→Gas_Tankless_Water_Heater,Electric_Tankless_Water_HeaterIndirect_Water_HeaterSemi_Instantaneous_Water_Heaterdefinitions.csvfor all new tagsDesign decisions
isHeatedByrelationship toBoileris left for a future PR.Boilerbut keeping the initial hierarchy simple. Can be extended later.Storage_Water_Heateris kept as a distinct combined-appliance class rather than modeling it as aWater_Heater hasPart Storage_Tank.Test plan
python generate_brick.pycompletes successfully (51418 triples, no new errors)