forked from plantbreeding/brapi-Java-ProdServer
-
Notifications
You must be signed in to change notification settings - Fork 0
[BI-2903] Support for program_id in germplasm table #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
2bd1d47
Create migration script, add programDbId to entity and model
jloux-brapi 2bad4ff
Support for programId in GermplasmApi
jloux-brapi bd8e00a
Merge branch 'feature/BI-2996' into feature/BI-2903
jloux-brapi ad1c04a
Merge branch 'feature/BI-2996' into feature/BI-2903
jloux-brapi 7248c4d
Merge branch 'feature/BI-2996' into feature/BI-2903
jloux-brapi ef2bade
Merge branch 'feature/BI-2996' into feature/BI-2903
jloux-brapi 5a39677
Fix createEntities in batch error, address migration concerns
jloux-brapi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
40 changes: 40 additions & 0 deletions
40
src/main/resources/db/migration/V006_003__add_program_id_to_germplasm_and_migrate.sql
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| ALTER TABLE germplasm | ||
| ADD COLUMN program_id UUID; | ||
|
|
||
| ALTER TABLE germplasm | ||
| ADD CONSTRAINT germplasm_program_fk | ||
| FOREIGN KEY (program_id) | ||
| REFERENCES public.program(id); | ||
|
|
||
| CREATE INDEX germplasm_program_idx ON germplasm (program_id, id); | ||
|
|
||
| UPDATE germplasm set program_id = pquery.program_id | ||
| FROM ( | ||
| SELECT g.id AS germplasm_id, p.id AS program_id | ||
| FROM germplasm g | ||
| JOIN germplasm_external_references gex ON g.id = gex.germplasm_entity_id | ||
| JOIN external_reference ex ON ex.id = gex.external_references_id | ||
| JOIN external_reference ex2 ON ex2.external_reference_id = ex.external_reference_id | ||
| JOIN program_external_references pex ON pex.external_references_id = ex2.id | ||
| JOIN program p ON p.id = pex.program_entity_id | ||
| WHERE ex.external_reference_source = 'breedinginsight.org/programs' AND ex2.external_reference_source = 'breedinginsight.org') pquery | ||
| WHERE id = pquery.germplasm_id; | ||
|
|
||
| -- Assertion to ensure all germplasm are now associated with a program | ||
| DO $$ | ||
| DECLARE | ||
| germs_without_program_count integer; | ||
|
|
||
| BEGIN | ||
| SELECT COUNT(*) | ||
| INTO germs_without_program_count | ||
| FROM germplasm g | ||
| WHERE g.program_id IS NULL; | ||
|
|
||
| IF germs_without_program_count <> 0 THEN | ||
| RAISE EXCEPTION | ||
| 'V006.003 After migration, expected all germplasm rows to have program_id set, but there are % rows with program_id not set', | ||
| germs_without_program_count; | ||
| END IF; | ||
| END | ||
| $$; | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should also constrain on the germplasm exref source being
breedinginsight.org/programsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a constraint on this search query and also
breedinginsight.orgexref fromex2. Tested locally, and on rel-test, prod