[BI-2919]: Study Cache 2 - Untangle bi-generated exRefIds from BrAPI studyDbIds - #549
Open
humsika wants to merge 6 commits into
Open
[BI-2919]: Study Cache 2 - Untangle bi-generated exRefIds from BrAPI studyDbIds#549humsika wants to merge 6 commits into
humsika wants to merge 6 commits into
Conversation
# Conflicts: # src/main/java/org/breedinginsight/brapi/v2/dao/BrAPIObservationDAO.java # src/main/java/org/breedinginsight/brapi/v2/dao/BrAPIStudyDAO.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Story: BI-2919
Updates the study-related BI API flows to consistently use the real BrAPI
studyDbIdinstead of the BI-generated ID stored in/studiesexternal references.This change:
studyDbIdin study, observation unit, and observation API responses.studyDbId.studyDbIdssearch field.studyDbIdvalues.observation.studyDbIdwithstudyPIO.getId().Dependencies
Testing
Added and updated unit and integration-test coverage to use real BrAPI
studyDbIdvalues instead of extracting study IDs from/studiesexternal references.Unit/integration testing:
Manual testing:
Start bi-api and bi-web, then sign in and open a program containing an existing experiment.
Open the browser developer tools, select the Network tab, and navigate to the Experiments tab.
Find the /studies request and inspect its response.
Checklist: