Skip to content

[BI-2971] - Improve default sample submission sorting #542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
humsika merged 1 commit into from
Aug 24, 2026
Merged

[BI-2971] - Improve default sample submission sorting #542

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/main/java/org/breedinginsight/services/SampleSubmissionService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,11 @@ public Optional<DownloadFile> generateDArTFile(Program program, UUID submissionI
columns.add(Column.builder().value(SampleSubmissionImport.Columns.TISSUE).dataType(Column.ColumnDataType.STRING).build());
columns.add(Column.builder().value(SampleSubmissionImport.Columns.COMMENTS).dataType(Column.ColumnDataType.STRING).build());

//TODO sort the samples first
//Sort samples first. May be updated to use BrAPI server sorting after cache removal changes are merged
submission.get().getSamples().sort(Comparator.comparing(BrAPISample::getPlateName)
.thenComparing(BrAPISample::getColumn)
.thenComparing(BrAPISample::getRow));

List<Map<String, Object>> rows = new ArrayList<>();
submission.get().getSamples().forEach(sample -> {
Map<String, Object> row = new HashMap<>();
Expand Down
Loading