WCN-2596: Align Node.js versions across release and CI - #9664
Merged
zahin-mohammad merged 1 commit intoSep 5, 2026
Merged
Conversation
Contributor
zahin-mohammad
force-pushed
the
zahinmohammad/wcn-2596-fix-bitgojs-release-gate-to-use-nodejs-22
branch
from
September 4, 2026 22:39
ccddb01 to
67355de
Compare
zahin-mohammad
changed the title
Keep the compatibility matrix on explicit Node.js major lines. Use .nvmrc for the release gate and single-version CI jobs and cache keys. TICKET: WCN-2596
zahin-mohammad
force-pushed
the
zahinmohammad/wcn-2596-fix-bitgojs-release-gate-to-use-nodejs-22
branch
from
September 4, 2026 22:41
67355de to
0fb22b5
Compare
zahin-mohammad
marked this pull request as ready for review
September 4, 2026 22:43
Marzooqa
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bitgotarball installation gate usenode-version-file: '.nvmrc', currently Node.js24.13.0.22.xand24.x.code-quality,browser-test, anddockerfile-checkjobs usenode-version-file: .nvmrcas well..nvmrcin the affected dependency-cache keys so an intentional Node.js upgrade cannot reuse the previous runtime's cache.Why
The BitGoJS release job failed with
EBADENGINE:bitgo@52.11.0requires Node.js 22 or newer, but the pre-publish gate explicitly switched to Node.js 20.The npm shrinkwrap is the published lockfile that pins dependency versions. This change validates it on the same explicitly reviewed Node.js version used by the repository and release workflow. Rolling selectors such as
lts/*andlts/-1are intentionally avoided because they can advance CI without a source change or code review.Warning
The release gate now validates the
.nvmrcruntime, currently Node.js 24.13.0, rather than the minimum supported Node.js 22 line. The explicit unit-test matrix continues to cover22.xcompatibility.Validation
.github/workflows/npmjs-release.ymland.github/workflows/ci.ymlwith the repository's JavaScript YAML parser:YAML parse: OK.actions/setup-node@v6step inci.ymlusenode-version-file: .nvmrc.[22.x, 24.x].git diff --checksuccessfully.yarn commitlint --from=origin/master -V:0 problems, 0 warnings.Risk
Low. Node.js upgrades remain explicit changes to
.nvmrc, and the cache keys change with that file. The release guard still runs before thebitgopublication step withengine-strict=true, which makes npm reject incompatible engine ranges.Ticket
WCN-2596: Align BitGoJS Node.js versions across release and CI