fix(sdk-coin-sui): guard precomputedMaterial shape in signRecoveryTx - #9654
Merged
Conversation
Contributor
Contributor
|
|
WRW passes openSSLBytes as the second positional arg to recover() for EVM coins. SUI's recoverConsolidations PR added precomputedMaterial as the second arg, causing the ArrayBuffer to be consumed as signing material — resulting in JSON.parse(undefined) at runtime. Ticket: WCI-1439
vibhavgo
force-pushed
the
WCI-1439-fix-sui-precomputed-material
branch
from
September 4, 2026 08:28
3d4bca7 to
f508e14
Compare
vibhavgo
marked this pull request as ready for review
September 4, 2026 08:28
prithvishet2503
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Guards against non-
EddsaSigningMaterialvalues being passed asprecomputedMaterialinsignRecoveryTransaction. WRW passesopenSSLBytes(an ArrayBuffer) as the second positional arg torecover()for EVM coins; after PR #9496 addedprecomputedMaterialas the second arg to SUI'srecover(), that ArrayBuffer was being consumed as signing material — producingJSON.parse(undefined)at runtime.Linear: WCI-1439
Changes
precomputedMaterialinsignRecoveryTransactionbefore using itgetEddsaSigningMaterialwhen the value is not a validEddsaSigningMaterialTest Plan
yarn unit-testinmodules/sdk-coin-sui— 155 passingrecoverConsolidationsis unaffected: its only caller passesundefinedor the return value ofgetEddsaSigningMaterial(always a valid shape)