fix(abstract-eth,sdk-core): use coin chain ID when deriving signableHex (WCI-1398) - #9602
Merged
Merged
Conversation
Contributor
Marzooqa
force-pushed
the
fix-wci-1398-chain-id-in-assert
branch
from
August 31, 2026 08:02
69837ea to
fca2fe1
Compare
Marzooqa
force-pushed
the
fix-wci-1398-chain-id-in-assert
branch
from
August 31, 2026 09:12
fca2fe1 to
b40a287
Compare
parasgarg-bitgo
requested changes
Aug 31, 2026
Marzooqa
force-pushed
the
fix-wci-1398-chain-id-in-assert
branch
from
August 31, 2026 14:11
b40a287 to
6962d17
Compare
…ex (WCI-1398) Unsigned EVM transactions have v=0 — no chain ID in the serialized bytes. TransactionFactory.fromSerializedData without an explicit Common defaults to mainnet (chain ID 1), while the server computes signableHex with the correct chain ID (e.g. 97 for BSC testnet), causing a false-positive tamper error on every signing flow. Fix: pass getCustomChainCommon(this.getChainId()) when parsing the serialized tx so the EIP-155 preimage is derived with the correct chain ID. For coins without CoinFeature.EIP1559 (BSC, XDC), pin the Common hardfork to petersburg so type-2 txs cannot be decoded as EIP-1559. Re-enable the assertSignableConsistency call in ecdsaMPCv2. TICKET: WCI-1398 Co-authored-by: Cursor <cursoragent@cursor.com>
Marzooqa
force-pushed
the
fix-wci-1398-chain-id-in-assert
branch
from
August 31, 2026 14:22
6962d17 to
3762bc6
Compare
parasgarg-bitgo
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #9600. Re-enables the
assertSignableConsistencycall with the correct fix.v=0— no chain ID in the serialized bytes.TransactionFactory.fromSerializedDatawithout an explicitCommondefaults to mainnet (chain ID 1), while the server computessignableHexwith the correct chain ID (e.g. 97 for BSC testnet). Derivation mismatch → false-positive tamper error.getCustomChainCommon(this.getChainId())when parsingserializedTxHexso the EIP-155 preimage is derived with the coin's actual chain IDassertSignableConsistencycall inecdsaMPCv2.tssignableHexwith the correctCommonTest plan
repro-tbsc.js,repro-txdc.js) produce txids against staging@wp_api_tbscand@wp_api_txdcpassFixes: WCI-1398