revert(abstract-eth): remove signableHex consistency check (WCI-1398) - #9601
Closed
lokesh-bitgo wants to merge 1 commit into
Closed
revert(abstract-eth): remove signableHex consistency check (WCI-1398)#9601lokesh-bitgo wants to merge 1 commit into
lokesh-bitgo wants to merge 1 commit into
Conversation
Contributor
Contributor
Author
|
Fix has been raised here - #9600 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
signableHexvsserializedTxHexconsistency check for BSC/XDC TSS MPCv2.sendManyfor BSC, BSC:BUSD, and TXDC: unsigned txs often have emptyvwhilesignableHexuses EIP-155v=chainId, and the SDK parsed without the coinCommon(defaults to Ethereum chainId 1).vhandling.Test plan
sendManyon Test no longer throwssignableHex is inconsistent with serializedTxHexbsc:busdsendManyon Test succeedssendManyon Test succeedsverifyTransactionstill runs forTSS_VERIFY_USE_SERIALIZED_TX_HEXcoins (only the extra consistency assert is removed)