Minimum Distance Operator - #482
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #482 +/- ##
==========================================
- Coverage 89.87% 89.86% -0.01%
==========================================
Files 48 48
Lines 13346 13374 +28
==========================================
+ Hits 11995 12019 +24
- Misses 1351 1355 +4
🚀 New features to boost your workflow:
|
dfremont
left a comment
There was a problem hiding this comment.
Looks good (just one comment), but please add a .. note to the Operator Reference section for distance from explaining that when passed objects it just computes the distance between their positions (i.e. their centers), and that if you want to find the separation between two objects taking into account their shape and size you should use minimum distance from.
Also the minimum distance from entry needs a .. version-added directive. You could put version 3.2 for now I guess, or maybe something like "unreleased".
Co-authored-by: Daniel Fremont <dfremont@ucsc.edu>
dfremont
left a comment
There was a problem hiding this comment.
Looks good, thanks Eric!
Description
Adds an operator to compute the minimum distance between two objects, accounting for shape, size, etc... To vote on the name of this operator, please use this poll.
Issue Link
N/A
Checklist
pytestand/or other meansAdditional Notes
Please do not merge until poll results are finalized and I have updated the code to reflect them.