Skip to content

Fix issue with using the same Contentful video for both portrait and landscape #66

Description

@weotch

We observed that using the same asset for both the video and portraitVideo src properties of @react-visual/contentful resulted in no video loading at one of the breakpoints. Maybe there is some issue with both responsive sources having the same URL?

Regardless, I think a good solve could be to add some deduping, maybe in packages/react/src/LazyVideo/LazyVideoServer.tsx, that filters out duplicates for both image and video.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions