Skip to content

develop -> master - #193

Open
taejinn wants to merge 3 commits into
masterfrom
develop
Open

develop -> master#193
taejinn wants to merge 3 commits into
masterfrom
develop

Conversation

@taejinn

@taejinn taejinn commented Aug 9, 2026

Copy link
Copy Markdown

작업 내용

  • 프로덕션 배포 Slack 메시지의 브랜치 표기를 master로 수정했습니다.
  • 삭제 게시글 조회 SQL의 컬럼명을 실제 DB 스키마에 맞게 수정했습니다.
    • is_deleteis_deleted

포함 PR

확인 사항

  • develop → master 변경 파일 확인
  • 게시판 크롤링 SQL 실행 가능 여부 확인
  • Python 파일 구문 검사 통과

Summary by CodeRabbit

  • Bug Fixes
    • Corrected article deletion processing so active articles are selected reliably.
  • Chores
    • Updated production deployment notifications to display the correct “[Production]” label, making deployment results easier to identify.

@coderabbitai

coderabbitai Bot commented Aug 9, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The deployment notification now identifies production results correctly. The article deletion query now uses the is_deleted column.

Changes

Production notification label

Layer / File(s) Summary
Production notification title
.github/workflows/deploy-prod.yml
The deployment result Slack notification title changed from [Develop] to [Production].

Article deletion filter

Layer / File(s) Summary
Deletion-status query filter
crawling/koreatech_article/delete_article.py
The article-selection query now filters with is_deleted = 0.

Estimated code review effort: 2 (Simple) | ~5 minutes

Possibly related PRs

Suggested reviewers: kongwoojin

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the main change: merging the develop branch into the master branch.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch develop

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/deploy-prod.yml:
- Line 69: Update the branch value in the production notification text to master
instead of develop, while preserving the existing workflow expressions and
message formatting.
- Line 69: Update the Slack payload construction in the deployment notification
step to serialize the message with jq --arg rather than interpolating COMMIT_MSG
directly into JSON. Pass COMMIT_MSG and the GitHub context values through the
environment, ensuring quotes, backslashes, and other special characters are
escaped before the payload is sent.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: d4719e04-ce55-4c3c-b6f9-9c17ed1fc987

📥 Commits

Reviewing files that changed from the base of the PR and between 247dcc9 and a6148b1.

📒 Files selected for processing (2)
  • .github/workflows/deploy-prod.yml
  • crawling/koreatech_article/delete_article.py

-H 'Content-Type: application/json' \
-d "{
\"text\": \"${ICON} *[Develop] ${STATUS}*\n• Repo: ${{ github.repository }}\n• Branch: develop\n• Author: @${{ github.actor }}\n• Commit: ${COMMIT_MSG}\n• Duration: ${DURATION}\n• <${ACTIONS_URL}|Actions 보기>\"
\"text\": \"${ICON} *[Production] ${STATUS}*\n• Repo: ${{ github.repository }}\n• Branch: develop\n• Author: @${{ github.actor }}\n• Commit: ${COMMIT_MSG}\n• Duration: ${DURATION}\n• <${ACTIONS_URL}|Actions 보기>\"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Use master in the branch field.

This workflow runs only for refs/heads/master, but the result notification still sends Branch: develop. Replace develop with master so the deployment metadata is accurate.

🧰 Tools
🪛 zizmor (1.29.0)

[error] 69-69: code injection via template expansion (template-injection): may expand into attacker-controllable code

(template-injection)

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/deploy-prod.yml at line 69, Update the branch value in the
production notification text to master instead of develop, while preserving the
existing workflow expressions and message formatting.

🩺 Stability & Availability | 🟡 Minor | ⚡ Quick win

Serialize the Slack payload before sending it.

COMMIT_MSG is inserted into the JSON string without escaping. A commit subject containing " or \ can make the payload invalid, causing Slack to reject the deployment result. Build the payload with a JSON serializer such as jq --arg, and pass GitHub context values through env.

🧰 Tools
🪛 zizmor (1.29.0)

[error] 69-69: code injection via template expansion (template-injection): may expand into attacker-controllable code

(template-injection)

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/deploy-prod.yml at line 69, Update the Slack payload
construction in the deployment notification step to serialize the message with
jq --arg rather than interpolating COMMIT_MSG directly into JSON. Pass
COMMIT_MSG and the GitHub context values through the environment, ensuring
quotes, backslashes, and other special characters are escaped before the payload
is sent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants