Conversation
fix: 게시판 크롤링 중단 문제 수정
📝 WalkthroughWalkthroughThe deployment notification now identifies production results correctly. The article deletion query now uses the ChangesProduction notification label
Article deletion filter
Estimated code review effort: 2 (Simple) | ~5 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/deploy-prod.yml:
- Line 69: Update the branch value in the production notification text to master
instead of develop, while preserving the existing workflow expressions and
message formatting.
- Line 69: Update the Slack payload construction in the deployment notification
step to serialize the message with jq --arg rather than interpolating COMMIT_MSG
directly into JSON. Pass COMMIT_MSG and the GitHub context values through the
environment, ensuring quotes, backslashes, and other special characters are
escaped before the payload is sent.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: d4719e04-ce55-4c3c-b6f9-9c17ed1fc987
📒 Files selected for processing (2)
.github/workflows/deploy-prod.ymlcrawling/koreatech_article/delete_article.py
| -H 'Content-Type: application/json' \ | ||
| -d "{ | ||
| \"text\": \"${ICON} *[Develop] ${STATUS}*\n• Repo: ${{ github.repository }}\n• Branch: develop\n• Author: @${{ github.actor }}\n• Commit: ${COMMIT_MSG}\n• Duration: ${DURATION}\n• <${ACTIONS_URL}|Actions 보기>\" | ||
| \"text\": \"${ICON} *[Production] ${STATUS}*\n• Repo: ${{ github.repository }}\n• Branch: develop\n• Author: @${{ github.actor }}\n• Commit: ${COMMIT_MSG}\n• Duration: ${DURATION}\n• <${ACTIONS_URL}|Actions 보기>\" |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Use master in the branch field.
This workflow runs only for refs/heads/master, but the result notification still sends Branch: develop. Replace develop with master so the deployment metadata is accurate.
🧰 Tools
🪛 zizmor (1.29.0)
[error] 69-69: code injection via template expansion (template-injection): may expand into attacker-controllable code
(template-injection)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.github/workflows/deploy-prod.yml at line 69, Update the branch value in the
production notification text to master instead of develop, while preserving the
existing workflow expressions and message formatting.
🩺 Stability & Availability | 🟡 Minor | ⚡ Quick win
Serialize the Slack payload before sending it.
COMMIT_MSG is inserted into the JSON string without escaping. A commit subject containing " or \ can make the payload invalid, causing Slack to reject the deployment result. Build the payload with a JSON serializer such as jq --arg, and pass GitHub context values through env.
🧰 Tools
🪛 zizmor (1.29.0)
[error] 69-69: code injection via template expansion (template-injection): may expand into attacker-controllable code
(template-injection)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.github/workflows/deploy-prod.yml at line 69, Update the Slack payload
construction in the deployment notification step to serialize the message with
jq --arg rather than interpolating COMMIT_MSG directly into JSON. Pass
COMMIT_MSG and the GitHub context values through the environment, ensuring
quotes, backslashes, and other special characters are escaped before the payload
is sent.
작업 내용
master로 수정했습니다.is_delete→is_deleted포함 PR
확인 사항
develop → master변경 파일 확인Summary by CodeRabbit