[POSTGRESQL] az postgresql db create: Bug fix, correct property bag for creating new database - #33951
[POSTGRESQL] az postgresql db create: Bug fix, correct property bag for creating new database#33951nasc17 wants to merge 1 commit into
az postgresql db create: Bug fix, correct property bag for creating new database#33951Conversation
|
Hi nasc17, |
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
|
/azp run |
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
There was a problem hiding this comment.
Pull request overview
Fixes a regression in the PostgreSQL Flexible Server database create path where az postgresql db create (aka az postgres flexible-server db create) stopped honoring --charset/--collation due to sending an incorrect request payload shape to the service.
Changes:
- Update the database create request body to use the correct
propertiesbag forcharset/collation. - Extend the flexible server DB scenario test to pass
--charset/--collationand assert they are present in create/show output.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/azure-cli/azure/cli/command_modules/postgresql/commands/database_commands.py |
Sends charset/collation under properties when creating a database, matching the service contract. |
src/azure-cli/azure/cli/command_modules/postgresql/tests/latest/test_postgres_flexible_commands_db.py |
Adds coverage ensuring --charset/--collation are applied and observable via create/show. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
POSTGRESQL |
Live test results —
|
There was a problem hiding this comment.
CI Summary
Live test (azdev test) passed. However, Azure Pipelines CI failed on the Azure.azure-cli check: Build #20260821.41 failed with 3 errors / 4 warnings (build details).
53/55 checks passed; 1 failed, 0 pending.
@d0b5e0c16 please review the build log linked above and address the reported errors/warnings before this PR can be merged.
🤖 PR Validation — ️✔️ All clear
Related command
az postgresql db createDescription
Regressions: db create ignores --charset/--collation starting CLI 2.84.0
A controlled cross-version test on a separate PostgreSQL Flexible Server
confirmed:
Testing Guide
Test included
History Notes
[POSTGRESQL]
az postgresql db create: Correct property bag being sent for creating new databaseThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.