Skip to content

Bump morgan from 1.11.0 to 1.12.0 - #2761

Merged
Akanksha Jain (jainakanksha-msft) merged 5 commits into
mainfrom
dependabot/npm_and_yarn/morgan-1.12.0
Sep 2, 2026
Merged

Bump morgan from 1.11.0 to 1.12.0#2761
Akanksha Jain (jainakanksha-msft) merged 5 commits into
mainfrom
dependabot/npm_and_yarn/morgan-1.12.0

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Sep 1, 2026

Copy link
Copy Markdown
Contributor

Bumps morgan from 1.11.0 to 1.12.0.

Release notes

Sourced from morgan's releases.

1.12.0

What's Changed

New Contributors

Full Changelog: expressjs/morgan@1.11.0...1.12.0

Changelog

Sourced from morgan's changelog.

1.12.0

  • Security fix for CVE-2026-15603(GHSA-jxfw-x594-9x9m)
  • Allow format functions to return objects for streams in objectMode
  • Respect the NO_COLOR environment variable in the dev format
Commits
Maintainer changes

This version was pushed to npm by GitHub Actions, a new releaser for morgan since your current version.


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [morgan](https://github.com/expressjs/morgan) from 1.11.0 to 1.12.0.
- [Release notes](https://github.com/expressjs/morgan/releases)
- [Changelog](https://github.com/expressjs/morgan/blob/master/HISTORY.md)
- [Commits](expressjs/morgan@1.11.0...1.12.0)

---
updated-dependencies:
- dependency-name: morgan
  dependency-version: 1.12.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code labels Sep 1, 2026
Copilot AI lite review requested due to automatic review settings September 1, 2026 18:36
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code labels Sep 1, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@jainakanksha-msft

Copy link
Copy Markdown
Member

Copilot This PR was opened by Dependabot. Please take it the rest of the way before it's ready for human review:

  1. Impact analysis — review the PR diff/description to identify what changed, including the package name and old → new version, then check where that dependency is actually used in the codebase, or whether it is unused, and summarize the potential impact.
  2. Fix build/conflict issues — run npm ci --legacy-peer-deps, npm run build, and npm run lint; resolve any merge conflicts, build errors, or lint errors that surface.
  3. Tests — add or update tests under tests/** to cover the changed usage, and make sure they meaningfully validate the change (not just re-assert the version bump).
  4. Run the suite — run the relevant npm run test:* script(s) for the affected area (e.g. test:blob, test:queue, test:table) and keep fixing until they pass.
  5. Changelog — append one bullet to ChangeLog.md under ## Upcoming ReleaseGeneral:, matching the existing style and tone of the entries already there (package name in backticks, old → new version, why, and a one-line concise summary of any code changes made).
  6. Comments — review any existing PR comments and review threads, including resolved/hidden ones, and address anything actionable.
  7. Self-rate — rate this work 1-10 against: correctness, test coverage, changelog accuracy, build/lint health, and comment resolution.
  8. Iterate — if it's not a 10, keep improving until it is before finishing.
  9. Summary — your final response must use the following structure exactly (no free-form paragraph summary).

Impact analysis

  • Package:
  • Old version:
  • New version:
  • Change Impact:

Build/Conflict Issues

  • Commands:
  • Result:

Tests

  • Added:
  • Updated:
  • Result:

Run the Suite

  • Commands:
  • Status:

Changelog

  • Entry:
  • Location:

Comments

  • Reviewed:
  • Actions:

Self-Rate

  • Score:
  • Reasoning:

Summary

  • Why this matters:
  • Risk of not taking change:

…an 1.12.0

Co-authored-by: jainakanksha-msft <181211853+jainakanksha-msft@users.noreply.github.com>
Copilot AI review requested due to automatic review settings September 1, 2026 18:40
@dependabot
dependabot Bot removed the request for review from Copilot September 1, 2026 18:40

Copilot AI commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Copilot This PR was opened by Dependabot. Please take it the rest of the way before it's ready for human review:

  1. Impact analysis — review the PR diff/description to identify what changed, i...

Completed in 51c92d9.

  • Impact: morgan 1.11.0 → 1.12.0 (lockfile only; package.json already allows ^1.11.0). Azurite uses morgan("common", { stream: accessLogWriteStream }) in BlobRequestListenerFactory, QueueRequestListenerFactory and TableRequestListenerFactory, so the fix for CVE-2026-15603 (log forging via unescaped U+0085/U+2028/U+2029 in log tokens) applies directly to Azurite access logs. No source changes required.
  • Build/lint: npm ci --legacy-peer-deps, npm run build, npm run lint all clean; no merge conflicts.
  • Tests: added tests/common/accessLog.test.ts (3 cases: single log line per request, Unicode line-separator escaping, ASCII control-character escaping). Verified the Unicode case fails against morgan 1.11.0 and passes on 1.12.0.
  • Suites: npm run test:blob (568 passing), npm run test:queue (87 passing), npm run test:table (453 passing), plus tests/common.
  • Changelog: bullet appended under ## Upcoming ReleaseGeneral:.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The change is limited to a lockfile security update plus targeted regression tests and a changelog entry, with no production code modifications.

  1. Impact analysis

    • Package: morgan
    • Version change: 1.11.01.12.0 (lockfile-resolved)
    • Usage: Access logging via morgan("common", { stream: this.accessLogWriteStream }) in Blob/Queue/Table request listener factories
    • Impact and risk: Applies upstream escaping fixes for token values to mitigate log forging; risk is limited to access-log output formatting changes for affected characters.
  2. Build and conflict resolution

    • Commands run: - None
    • Issues found: - None
    • Result: - Not run in this review environment
  3. Tests

    • Tests added or updated: - tests/common/accessLog.test.ts
    • Coverage: - Adds regression coverage for escaped access-log token values (Unicode line separators and ASCII control chars)
    • Result: - Not run in this review environment
  4. Test suite

    • Commands run: - None
    • Passing: - None
    • Pending or failing: - Not run in this review environment
  5. Changelog

    • Entry added: - Yes
    • Location: - ChangeLog.md## Upcoming ReleaseGeneral
  6. PR comments

    • Threads reviewed: - None
    • Actions taken: - None
    • Unresolved items: - None
  7. Self-rating

    • Score: - 8/10
    • Reasoning: - Straightforward dependency security update with clear regression tests; limited residual risk due to upstream behavior changes affecting log output.
  8. Iteration

    • Improvements made after self-review:
      • None
  9. Summary

    • Why the update matters: - Addresses CVE-2026-15603 by ensuring access-log token values are safely escaped, preventing log record forgery.
    • Risk if not applied: - Potential for attacker-controlled values (e.g., Unicode line separators) to forge additional access log lines in downstream log parsers.
    • Final status: - Ready to approve
Review details
  • Files reviewed: 2/3 changed files
  • Comments generated: 0 new
  • Review effort level: Lite

@jainakanksha-msft

Copy link
Copy Markdown
Member

Copilot do we really need that test file?
We are just asserting the logging. That must be done at the morgan side no?
We are not testing any functionality. Can you justify the test file please

Co-authored-by: jainakanksha-msft <181211853+jainakanksha-msft@users.noreply.github.com>
Copilot AI review requested due to automatic review settings September 2, 2026 07:22
@dependabot
dependabot Bot removed the request for review from Copilot September 2, 2026 07:22

Copilot AI commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Copilot do we really need that test file?
We are just asserting the logging. That must be done at the morgan side no?
We are not testing any functionality. Can you justify the test file please

You're right — I removed it in c137756.

The test spun up its own Express app with morgan("common", ...) and asserted the escaping of token values. That escaping is entirely morgan's implementation and is already covered by morgan's own test suite; Azurite contributes no logic there (we just pass a format string and a write stream). So the test was effectively re-testing an upstream library and would only ever break on a dependency change, adding maintenance cost without validating any Azurite behavior.

The PR is now lockfile-only plus the ChangeLog entry, which I also updated to drop the mention of the removed test coverage.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The CVE remediation is currently lockfile-only while package.json still declares morgan as ^1.11.0, which can allow downstream installs/consumer lockfiles to remain on 1.11.x and makes the changelog note potentially misleading.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review details
  • Files reviewed: 1/2 changed files
  • Comments generated: 1
  • Review effort level: Lite

Comment thread ChangeLog.md Outdated

General:

- Updated the lockfile-resolved `morgan` version from 1.11.0 to 1.12.0 to fix log forging via Unicode line separators (U+0085, U+2028, U+2029) in access log tokens (CVE-2026-15603). Lockfile-only change, no source changes required.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot could you please validate this comment and take necessary action

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validated and applied. I updated the declared dependency from morgan: ^1.11.0 to ^1.12.0 in package.json (and aligned package-lock.json), then updated the changelog entry to reflect that this is not lockfile-only. Addressed in commit e5dde12.

Co-authored-by: jainakanksha-msft <181211853+jainakanksha-msft@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The PR is a straightforward dependency + lockfile update with an accurate changelog entry and no code-path changes in Azurite itself.

Review details
  • Files reviewed: 2/3 changed files
  • Comments generated: 0 new
  • Review effort level: Lite

@jainakanksha-msft
Akanksha Jain (jainakanksha-msft) merged commit 7cc52ef into main Sep 2, 2026
46 checks passed
@dependabot
dependabot Bot deleted the dependabot/npm_and_yarn/morgan-1.12.0 branch September 2, 2026 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants