Accept --wp auto-update as the CLI name for the auto-update mode - #4750
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The agent-facing skill update lacks required eval coverage, and its validation message omits the supported latest alias.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 6/6 changed files
- Comments generated: 2
- Review effort level: Balanced
1 task
wojtekn
approved these changes
Sep 3, 2026
Base automatically changed from
gcsecsey/wordpress-version-expectation
to
trunk
September 3, 2026 11:18
gcsecsey
force-pushed
the
gcsecsey/accept-auto-update-wp-value
branch
from
September 3, 2026 11:18
0674edb to
537ba04
Compare
Collaborator
📊 Performance Test ResultsComparing 537ba04 vs trunk app-size
site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff) |
wojtekn
added a commit
that referenced
this pull request
Sep 7, 2026
… picker (#4752) ## Related issues - Related to STU-2348 - Stacked on #4750 - Lifts the update-mode control from #4747 ## How AI was used in this PR I used Opus 5 for implementation and tests. ## Proposed Changes The WordPress version setting mixes two decisions: whether the site updates itself, and which version it is pinned to. #4702 fixes the wording of the single dropdown, but the two decisions still share one control. This PR splits them into an `Automatic updates` toggle and a version picker that's only shown when the toggle is off, so the picker only ever means "pin this version". While auto-update is on, the field reports the version the site runs. - Without a version list (no network, no cached versions) the control degrades to the old plain dropdown. - Turning auto-update off seeds the picker with the version the site already runs, or with the newest stable release for a site that does not exist yet. Beta or nightly are never set as defaults. ## Testing Instructions - Open a site, then Settings - Check that if `Automatic updates` is on, the field shows `Installed version: <version>`. - Turn the toggle off - Check that the `Version` picker appears, preselected to the version the site runs - Pick another version and check that `Save settings` becomes enabled - Go back, add a site, and open Advanced settings - Check the same toggle, and that turning it off preselects the newest stable release | State | Light | Dark | | --- | --- | --- | | Agentic UI settings auto-update | <img width="1948" height="1156" alt="CleanShot 2026-09-02 at 15 48 25@2x" src="https://github.com/user-attachments/assets/025f8019-21fc-4a7e-925e-8b7bfa535719" /> | <img width="1948" height="1196" alt="CleanShot 2026-09-02 at 15 50 34@2x" src="https://github.com/user-attachments/assets/dcf170df-aca5-49be-9c30-937252e8dbf6" /> | | Agentic UI settings pinned version | <img width="1948" height="1196" alt="CleanShot 2026-09-02 at 15 50 22@2x" src="https://github.com/user-attachments/assets/11107976-e350-4196-83c0-c0cd9e9942e4" /> | <img width="1948" height="1196" alt="CleanShot 2026-09-02 at 15 50 29@2x" src="https://github.com/user-attachments/assets/272622f9-92f4-43e5-b0ef-1277c45c9a16" /> | | Agentic UI new site auto-update | <img width="1022" height="1674" alt="CleanShot 2026-09-02 at 15 51 00@2x" src="https://github.com/user-attachments/assets/95bad3b3-4272-4bf4-a2fd-9d590b2b7b90" /> | <img width="1022" height="1674" alt="CleanShot 2026-09-02 at 15 50 43@2x" src="https://github.com/user-attachments/assets/a66cf8e7-69cf-4d51-b7f7-5539dcf18a02" /> | | Agentic UI new site pinned version | <img width="1022" height="1674" alt="CleanShot 2026-09-02 at 15 50 58@2x" src="https://github.com/user-attachments/assets/16ad7d46-6adc-4ce6-bd9b-c2af116ee3f4" /> | <img width="1022" height="1674" alt="CleanShot 2026-09-02 at 15 50 54@2x" src="https://github.com/user-attachments/assets/e8ba28bc-8dcf-4eb8-9a33-9837315d99c1" /> | | Classic UI settings auto-update | <img width="1168" height="1002" alt="CleanShot 2026-09-02 at 15 45 08@2x" src="https://github.com/user-attachments/assets/454e6c6a-6684-4255-bf22-642db5f69d87" /> | <img width="1172" height="1002" alt="CleanShot 2026-09-02 at 15 43 58@2x" src="https://github.com/user-attachments/assets/1e7cd9f7-5e78-4049-a2e9-7ce79fbefe65" /> | | Classic UI settings pinned version | <img width="1144" height="976" alt="CleanShot 2026-09-02 at 16 14 04@2x" src="https://github.com/user-attachments/assets/87fb754a-d450-4a73-bc4d-d0039ab1a785" /> | <img width="1168" height="1002" alt="CleanShot 2026-09-02 at 15 44 57@2x" src="https://github.com/user-attachments/assets/ee61bbae-7917-4b67-8d8d-72f89b536d52" /> | | Classic UI new site auto-update | <img width="924" height="1806" alt="CleanShot 2026-09-02 at 15 44 28@2x" src="https://github.com/user-attachments/assets/acd689a1-595e-4658-a252-8d3350c30a13" /> | <img width="924" height="1806" alt="CleanShot 2026-09-02 at 15 44 15@2x" src="https://github.com/user-attachments/assets/2eb727df-d326-4a7e-aabc-579d3d643818" /> | | Classic UI new site pinned version | <img width="924" height="1806" alt="CleanShot 2026-09-02 at 15 44 31@2x" src="https://github.com/user-attachments/assets/35541207-5db6-4774-ab1e-80c94df28a95" /> | <img width="924" height="1806" alt="CleanShot 2026-09-02 at 15 44 35@2x" src="https://github.com/user-attachments/assets/ceb28490-2f48-4dd4-b5bd-c6b3d2805282" /> | ## Pre-merge Checklist - [x] Have you checked for TypeScript, React or other console errors? --------- Co-authored-by: Wojtek Naruniec <wojtek@naruniec.me> Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
How AI was used in this PR
I used Opus 5 for implementation and tests.
Proposed Changes
#4702 renames the "latest" WordPress version option to "Auto-update" in both UIs. This PR updates the naming in the CLI to keep it consistent.
--wp auto-updatenow selects that mode, matching what the apps show.--wp latestkeeps working as an alias too, so existing scripts and blueprints are unaffected.latestis still the internal value, and it still names a cache directory, a segment of the wordpress.org download URL, and the persisted site setting. The alias is resolved where the CLI parses input and never reaches storage.Two side effects:
blueprint use --wpwas not validated at all. It needed the alias mapping anyway, and the shared coercion brings validation with it, so a bad value now fails at parse time instead of throwing from inside the download helper.site createsaidlatest (7.1); it now saysAuto-update (7.1), matching the apps.Testing Instructions
npm run cli:buildThe new value works
~/.studio/cli.json: the site should have"isWpAutoUpdating": true.lateststill works--wp 6.9--wp latestisWpAutoUpdatingshould gofalse, then back totrue. The site has to be runningfor
config set --wpto apply, sostudio startit first.Help text
site create --help,config set --helpandblueprint use --helpshould alldescribe
auto-updateand mention thatlatestis accepted.Pre-merge Checklist