[Design Exploration] Browser-style preview toolbar - #4746
Open
shaunandrews wants to merge 27 commits into
Open
Conversation
1 task
1 task
Resolve conflicts in the preview toolbar in favor of the branch's browser-style address bar, carrying trunk's @wordpress/ui 0.21.0 migration onto it: the renamed design tokens, the literal elevation shadow, and the label now required on KeyboardShortcut. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
|
@shaunandrews I merged trunk, resolved the conflict, tested, and fixed minor issues. I think it solves STU-2370. I see potential improvements:
|
wojtekn
marked this pull request as ready for review
September 9, 2026 10:49
Picking an element opens a note while picking stays on, so testing isPicking first made the note-dismiss branch unreachable and Escape jumped straight to the discard-everything prompt. Report state when a note is dropped so a later cancel isn't gated on a draft that no longer exists. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
|
Two more small things:
|
Collaborator
📊 Performance Test ResultsComparing e179a1d vs trunk app-size
site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff) |
Contributor
|
I've been testing it, and it's very clear and very easy to use. Great job, @shaunandrews. In addition to @wojtekn's comments above, I just have three small suggestions:
|
…app, including phpMyAdmin
…hen labels collapse
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
















Related issues
How AI was used in this PR
AI assisted with iterative implementation, refactoring, and test updates. Shaun directed the interaction and visual design through hands-on review of the running Studio preview, including toolbar spacing, responsive behavior, control states, icon treatment, and dark-mode corrections.
Proposed Changes
This is intentionally a design exploration. The interaction model and visual treatment are presented for feedback rather than as a final approved direction.
Current screenshots
The set below covers the address menu and recents, compact toolbar behavior, dark mode, and the disabled Database state.
Testing Instructions
Automated verification completed for the latest update:
npm test -- apps/ui/src/components/site-preview/address-bar.test.tsx apps/ui/src/components/site-preview/index.test.tsx apps/ui/src/components/site-preview/inspector-script.test.ts(65 tests)npm run typecheck -w @studio/uinpm run cli:build:uion the combined exploration branchPre-merge Checklist