fix(php-transformer): honor explicit block flow before inferring columns - #1631
Open
chubes4 wants to merge 1 commit into
Open
fix(php-transformer): honor explicit block flow before inferring columns#1631chubes4 wants to merge 1 commit into
chubes4 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1628.
Honor explicit normal-flow display evidence before inferring native Columns from semantic sidebar/content children. A wrapper with authored
display:blockmust remain a Group rather than acquiring an equal-width flex row and a Gutenberg column gap.The reduced fixture uses ordinary classes and semantic children. The fix adds no source-platform marker or site-specific exception.
Verification
php php-transformer/tests/unit/block-style-support-conversion.php: 138 assertions passed.composer testfromphp-transformer/: canonical, unit, 303 parity fixtures, distribution-shape and package-install checks passed.This fixes one proven layout inference defect. Full Potted site parity remains an independent acceptance gate after refreshing the paired importer package and reimporting.
AI Assistance
GPT-5.6 Terra via OpenCode traced the source and generated geometry, corrected the initial ownership diagnosis, implemented the generic inference guard and verified it. GPT-6 Astra via OpenCode reviewed the scope and diff and prepared publication. Chris directed the work and authorized direct execution while the orchestration control plane was blocked.