Produce semantic validation outcomes before report projection - #1630
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Continue #1360 by completing the semantic-parity producer boundary introduced on the consumer side in #1627.
SemanticParityReporter::evaluate()performs the existing analysis once and returns authoritative findings and comparison facts.SemanticParityEvaluationsupplies status directly and projects the unchanged full semantic report.HtmlCompilationconsumes semantic status/findings from the evaluation, not from the full report map.report()API as a projection facade over evaluation.Landmark/nav counting, menu pairing and carrier folding, typography and finding enrichment retain their existing sequencing. There is no reduced-evidence mode, skipped validation, or performance claim in this change.
Verification
Baseline:
6a50fba0d8874778b92f2d5b22ec9ff2d57a65eb.Candidate:
091f5dcd3ee14b4c36bc5cd1fb699c868cbec426(implementation plus return-documentation correction).transform_duration_ms.bf7a12f997cd6c8d47d9483bf50e6e3c215fe481f75b505cf405d5ad175446a2.WP_TESTS_DIRwas unset; actual CI and solved-site promotion remain required.Reproduce
From
php-transformer, after dependency installation and configuring child PHP memory:composer test REQUIRE_WP_TESTS=1 WP_TESTS_DIR=/path/to/wordpress-tests composer test:wordpress-integrationThe full-corpus command in #1627 applies unchanged: run it in separate checkouts of the baseline and candidate above with matching dependencies and compare outputs. The updated consumer inventory is
php-transformer/docs/html-validation-outcome-consumer-inventory.md.AI Assistance
OpenAI GPT-5.6 Terra via direct OpenCode implemented and lab-tested the producer boundary. GPT-6 Astra via OpenCode coordinated and reviewed the data flow, corrected the evaluation return documentation, independently expanded verification to the full corpus and targeted artifacts, and prepared this PR under Chris Huber's direction. No release or deployment was performed.