fix(php-transformer): collect direct inline styles - #1626
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1623.
Collect direct HTML inline styles through the existing author-stylesheet pipeline rather than converting already-collected CSS nodes into unsupported blocks. Preserve occurrence order, media, and type metadata. Keep media constraints in presentation analysis as well as emitted assets, and avoid re-adding inline styles when artifact compilation supplied the ordered stylesheet list.
Verification
From
php-transformer/:composer test:canonical: passed.composer test:parity: 303 fixtures passed.composer test:packaging: passed.php tests/unit/artifact-author-stylesheet-projection.php: passed, including mixed inline/external order and print-only layout negative coverage.composer validate --strict: passed.Real Studio URL import using Studio draft #3952 at
0920bd364, SSIcda5b2d3, and this candidatea854528b7completed all six routes of the public Potted Plant Design source with zero fallbacks, compared with 114 on the original producer. Build the paired SSI development ZIP against this branch, then use Studio'screate --from https://www.pottedplantdesign.com/ --static-site-importer-path <paired-zip>to reproduce.This is a scoped conversion repair, not a claim of full site parity. The follow-up existing-runtime review still reports desktop/mobile layout differences despite valid blocks. The standalone WordPress integration suite was unavailable because
WP_TESTS_DIRwas not configured; the Studio import supplied the real materialization check.AI Assistance
GPT-5.6 Terra via OpenCode implemented and self-reviewed the repair, added regressions, and ran producer gates. GPT-6 Astra via OpenCode reviewed the candidate, requested media/order corrections, and ran the paired Studio URL import and existing-runtime review. Chris directed the work and authorized direct execution while the orchestration control plane was blocked.