fix(php-transformer): recognize captured slideshow controls - #1604
Merged
Conversation
chubes4
marked this pull request as draft
September 8, 2026 08:57
…estimonials # Conflicts: # php-transformer/src/HtmlToBlocks/HtmlCompilation.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Add regression coverage for existing camel-cased carousel control recognition across generic metadata signals, including
data-testid, and retain image-slide text when no explicit caption fields are present.The transformer remains platform-agnostic: recognition is based on control and slideshow semantics, not a platform-specific branch.
Verification
composer validate --strictcomposer testphp tests/contract/production-acceptance-matrix.phpThe authored-carousel regression includes camel-cased previous/next control IDs, text-rich captured slide states, responsive counterparts, and serialized copy retention. A bounded two-slide DLA capture input compiles to
custom/authored-carouselwith slideshow presentation, two slides, and both testimonial strings.Runtime Coverage
The existing native authored-carousel companion provides frontend controls through the WordPress Interactivity API. This PR proves recognition and block serialization only. It does not claim browser playback, responsive visual parity, or full-site import completion.
The DLA multi-state capture prerequisite is now landed upstream; this PR consumes its generic captured markup without modifying DLA.
AI Assistance
GPT-5.6 Terra via OpenCode was used to inspect the merge, resolve the implementation, and run verification. GPT-6 Astra via OpenCode orchestrated the work. Chris Huber remains responsible for the submitted changes.