Consolidate RPC response hardening - #802
Merged
Merged
Conversation
…rpc-hardening # Conflicts: # shared/ts/ethereum.test.ts
…rpc-hardening # Conflicts: # shared/ts/ethereum.test.ts
…rpc-hardening # Conflicts: # shared/ts/ethereum.test.ts
…rpc-hardening # Conflicts: # shared/ts/ethereum.test.ts
…c-hardening # Conflicts: # shared/ts/ethereum.test.ts # shared/ts/ethereum.ts
…c-hardening # Conflicts: # shared/ts/ethereum.test.ts
- Expect mined-block hash validation errors - Include canonical block metadata in replacement discovery fixtures
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mainbehavior while combining strict transaction quantities, byte data, topics, query results, receipt/log identities, block/transaction identities, and raw broadcast hash checksmainand resolve the overlapping shared Ethereum test and implementation conflictsReplaces
This PR supersedes the following pull requests, which can be closed in favor of this consolidated change:
Validation
bun run tscbun test shared/ts/ethereum.test.ts— 87 passedbun test --preload ./bun-test-setup-ui.ts --timeout 300000 ui/coreShared/ts/tests/chainBackend.test.ts— 21 passedcd bots/open-oracle-arbitrager && bun test tests/monitoring/connectivity.test.ts— 18 passedcd bots/shared && bun test ./tests— 100 passedbun run format:checkbun run check:changedbun run check:generated-cleangit diff --checkFinal project review: 100/100, no findings.