Fix Windows installer fixture - #1
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review on ArchCode
Problem and author intent
The initial public-repository installer workflow generated Windows fixtures with PowerShell 7
Add-Type -OutputType ConsoleApplication. PowerShell 7 rejects that output type, so the fixture build stopped before the installer boundary ran. The repository needs a runnable Windows fixture so its installer gate proves both packaged executables survive download, checksum verification, extraction, and installation.What changed
Scope
CI and test-fixture only.
Risk assessment
Low. The change affects only generated test fixtures and CI checkout. Release binaries and installers are unchanged.
User impact
No direct user-facing change. The public installer gate now catches non-runnable Windows packages.
Testing
.github/workflows/installer-smoke-test.yml, jobWindows Installer. It builds the fixture, crosses a real localhost HTTP download boundary throughinstall.ps1, verifies the checksum, installs both executables, runs both installed processes, and asserts version0.31.0.Follow-ups and known issues
None.