Skip to content

Fix Windows installer fixture - #1

Merged
calvin-archastro merged 1 commit into
mainfrom
fix/windows-installer-fixture
Sep 3, 2026
Merged

Fix Windows installer fixture#1
calvin-archastro merged 1 commit into
mainfrom
fix/windows-installer-fixture

Conversation

@calvin-archastro

Copy link
Copy Markdown
Contributor

Review on ArchCode

Problem and author intent

The initial public-repository installer workflow generated Windows fixtures with PowerShell 7 Add-Type -OutputType ConsoleApplication. PowerShell 7 rejects that output type, so the fixture build stopped before the installer boundary ran. The repository needs a runnable Windows fixture so its installer gate proves both packaged executables survive download, checksum verification, extraction, and installation.

What changed

  • Compile the fixture with Windows' framework C# compiler, which emits a runnable console executable on the hosted Windows runner.
  • Keep the CLI and dashboard fixture behavior identical: both print the requested version.
  • Move checkout to the pinned Node 24-based v7 action.

Scope

CI and test-fixture only.

Risk assessment

Low. The change affects only generated test fixtures and CI checkout. Release binaries and installers are unchanged.

User impact

No direct user-facing change. The public installer gate now catches non-runnable Windows packages.

Testing

  • Canonical end-to-end proof: .github/workflows/installer-smoke-test.yml, job Windows Installer. It builds the fixture, crosses a real localhost HTTP download boundary through install.ps1, verifies the checksum, installs both executables, runs both installed processes, and asserts version 0.31.0.
  • YAML parsing and diff checks pass locally.
  • The GitHub-hosted Windows result is the required merge gate.

Follow-ups and known issues

None.

@calvin-archastro
calvin-archastro merged commit 7c16002 into main Sep 3, 2026
5 checks passed
@calvin-archastro
calvin-archastro deleted the fix/windows-installer-fixture branch September 3, 2026 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant