Visualizer Refactor - #139
Conversation
Switched to time-based visualization so trial-based no longer needed
ensures column styling collection is initialized when added to a workflow
Also ensure that test visualizer workflow has drain complete subject placeholders
This will presumably be necessary for merging with main with minimal merge conflicts
|
Pushed some changes/fixes to update reward delivery changes in flush/open functions and allow for SessionInfoVisualizer to ingest a serializable object and display values. Also added stage name to metadata visualizer. A couple of issues that still need to be adressed
|
|
Pushed more updates adding stage name to metadata bar and using trial index for bias |
|
Pushed fix for crashing behavior when ending session. Problem was arising when camera preview visualizer continued capturing images when camera stream was closed |
|
Experiencing bug where it seems like the response period is truncated somehow. When testing with new visualizers, mice received no rewards even though they were consistently licking. Upon further investigations, it seemed like mice were not licking within the response period but immediately after. Comparing the old vs new visualizers, it seems like the quiescent period is missing from the trial graph, but I suspect this is actually effecting the response deadline instead. When running mice with the old visualizers with identical parameters, we did not see mice missing response deadlines and consistently making choices at the very beginning of the response period. These images were produced with identical task logics 
|
bruno-f-cruz
left a comment
bruno-f-cruz
left a comment
There was a problem hiding this comment.
@RoboDoig This looks great Andrew! thanks. I left a few notes after a quick review just to make sure we dont run into issues later!
There was a problem hiding this comment.
@RoboDoig Some context is missing here: there was a reason the previous visualizer was done at the OpenGL layer. If I understand correctly, this observable is allocating 3 frames on each Select call. These cameras can be quite high frame rate (500fps), not sure this will scale. Have you benchmarked it?
There was a problem hiding this comment.
these files should be ignored and not committed
| @@ -18,9 +18,9 @@ | |||
| <Property Name="SessionPath" /> | |||
| </Expression> | |||
| <Expression xsi:type="IncludeWorkflow" Path="AllenNeuralDynamics.Core:ReadSchemas.bonsai"> | |||
4 participants
This PR refactors the dynamic foraging visualizers to use a full Bonsai ImGui approach according the the requirements outlined in the visualizer refactor milestone
Addresses issues #99, #100, #101, #102, #103, #104, #105.
Individual visualizers take as input an observable source that describes their parent layout group (e.g. tab area, table window) such that visualizers can be reorganised within a parent layout structure. Generally, data is mapped to visualizers by externalized subject names corresponding to the appropriate data source or event.