Fix Inspector mobile safe areas and preview scaling - #91
Closed
muxammadreza wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
Named device presets currently write one shared
safeAreaInsetsvalue. The host safe-area effect then exits for non-custom presets, so selecting a mobile device replaces the host chrome insets. For example, an iPhone 15 preview reports its 34 px bottom device inset instead of preserving ChatGPT's 150 px fullscreen bottom inset.Fullscreen device frames can also extend beyond the visible preview stage. Host chrome may then overlap the iframe's interactive area and receive pointer hit tests intended for controls near the bottom of the simulated viewport.
Behavior before and after
Before:
After:
deviceSafeArea,hostSafeArea, and an optional explicitsafeAreaOverridemax(deviceInset, hostInset)independently for every edge59 / 0 / 150 / 0(top / right / bottom / left)59 / 16 / 138 / 16hostContext.containerDimensionsretain the original simulated dimensionsTesting
pnpm --filter sunpeak exec vitest run(575 passed)pnpm --filter sunpeak typecheckpnpm --filter sunpeak buildGeneric regression coverage includes ChatGPT and Claude safe-area composition, URL/stored preference precedence, iPhone 15, iPhone SE and iPad scaling, and separation of stage geometry from the iframe viewport.