Skip to content

[PWGUD] small code additions to finetune the analysis - #17467

Merged
rolavick merged 3 commits into
AliceO2Group:masterfrom
jgcn:finetune
Aug 15, 2026
Merged

[PWGUD] small code additions to finetune the analysis#17467
rolavick merged 3 commits into
AliceO2Group:masterfrom
jgcn:finetune

Conversation

@jgcn

@jgcn jgcn commented Aug 15, 2026

Copy link
Copy Markdown
Collaborator

Adding histograms for single-arm pile-up correction
Adding tags for TOF info in tracks

@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 2 warnings, 🔕 0 disabled

Please consider the following formatting changes to AliceO2Group#17467
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 585bd03 at 2026-08-15 13:53:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 3 errors and 0 warnings.'
Found 3 errors and 0 warnings.
++ [[ 3 -gt 0 ]]
++ cat /sw/BUILD/ea9b398dc803655904fcc634cbd09068e90ac3b8/O2Physics-code-check/errors.txt
PWGUD/Tasks/upcVmRof.cxx:703:17: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGUD/Tasks/upcVmRof.cxx:722:17: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGUD/Tasks/upcVmRof.cxx:768:5: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
++ [[ 0 -gt 0 ]]
++ [[ 3 -gt 0 ]]
++ exit 1
--

Full log here.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 833f9b9 at 2026-08-15 16:40:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 3 errors and 0 warnings.'
Found 3 errors and 0 warnings.
++ [[ 3 -gt 0 ]]
++ cat /sw/BUILD/8a35f0e58b45bc9b1ff448f8bc8ab65be6f89e9a/O2Physics-code-check/errors.txt
PWGUD/Tasks/upcVmRof.cxx:703:17: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGUD/Tasks/upcVmRof.cxx:722:17: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGUD/Tasks/upcVmRof.cxx:768:5: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
++ [[ 0 -gt 0 ]]
++ [[ 3 -gt 0 ]]
++ exit 1
--

Full log here.

@rolavick
rolavick merged commit 3695b2c into AliceO2Group:master Aug 15, 2026
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants