Skip to content

[PWGLF] Add more QA hist to check in hStrangenessCorrelation.cxx - #17459

Merged
romainschotter merged 2 commits into
AliceO2Group:masterfrom
kcui1:AddMoreHistInPairLossProcess
Aug 14, 2026
Merged

[PWGLF] Add more QA hist to check in hStrangenessCorrelation.cxx#17459
romainschotter merged 2 commits into
AliceO2Group:masterfrom
kcui1:AddMoreHistInPairLossProcess

Conversation

@kcui1

@kcui1 kcui1 commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

add few hist to to QA, basically in Rec and final pair match

@github-actions github-actions Bot added the pwglf label Aug 14, 2026
@github-actions github-actions Bot changed the title Add more QA hist to check in hStrangenessCorrelation.cxx [PWGLF] Add more QA hist to check in hStrangenessCorrelation.cxx Aug 14, 2026
@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 12 errors, ⚠️ 2 warnings, 🔕 0 disabled

@alibuild

alibuild commented Aug 14, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 6ce1fb2 at 2026-08-14 15:58:

++ set -euo pipefail
++ [[ -d /sw/slc9_x86-64/Clang/v20.1.7-24 ]]
+++ realpath /sw/BUILD/5631eb7458764e02fb25a43a9793f1e4bf26ab8b/O2Physics-code-check/../../O2Physics-latest/O2Physics
++ O2PHYSICS_BUILDDIR=/sw/BUILD/d559ba52e4c6e250b3e5b46dfc4b712292bc055f/O2Physics
++ cp /sw/BUILD/d559ba52e4c6e250b3e5b46dfc4b712292bc055f/O2Physics/compile_commands.json .
+++ python3 -c 'import json, os; print(os.path.commonpath([x["file"] for x in json.loads(open("compile_commands.json").read()) if "sw/BUILD" not in x["file"] and "G__" not in x["file"] and x["file"].endswith(".cxx")]))'
++ O2PHYSICS_SRC=/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0
++ pushd /sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0
/sw/SPECS/slc9_x86-64/O2Physics-code-check/1.0-local638/O2Physics-code-check.sh: line 16: pushd: /sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0: No such file or directory

Full log here.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for 6ce1fb2 at 2026-08-14 16:36:

No log files found

Full log here.

@romainschotter
romainschotter enabled auto-merge (squash) August 14, 2026 14:38
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 40150bc at 2026-08-14 16:59:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 50 errors and 0 warnings.'
Found 50 errors and 0 warnings.
++ [[ 50 -gt 0 ]]
++ cat /sw/BUILD/dfc4aafd589925937e75131328c10ad462149e98/O2Physics-code-check/errors.txt
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:95:8: error: constructor does not initialize these fields: ccdb, pdgDB [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:721:5: error: Variable 'radius' with floating point type 'double' should not be used as a loop counter [clang-analyzer-security.FloatLoopCounter,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:1097:5: error: Variable 'r' with floating point type 'double' should not be used as a loop counter [clang-analyzer-security.FloatLoopCounter,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:1527:75: error: use designated initializer list to initialize 'PairLossPairKey' [modernize-use-designated-initializers,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:3005:9: error: the 'empty' method should be used to check for emptiness instead of comparing to an empty object [readability-container-size-empty,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:3183:9: error: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:3413:9: error: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:3450:9: error: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:3605:9: error: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:3690:11: error: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:3747:13: error: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:3806:13: error: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:3856:11: error: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:3959:13: error: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:3989:9: error: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4162:15: error: boolean expression can be simplified by DeMorgan's theorem [readability-simplify-boolean-expr,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4164:30: error: redundant explicit casting to the same type 'int64_t' (aka 'long') as the sub-expression, remove this casting [readability-redundant-casting,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4178:26: error: redundant explicit casting to the same type 'int64_t' (aka 'long') as the sub-expression, remove this casting [readability-redundant-casting,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4189:28: error: redundant explicit casting to the same type 'int64_t' (aka 'long') as the sub-expression, remove this casting [readability-redundant-casting,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4263:13: error: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4267:31: error: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4381:26: error: redundant explicit casting to the same type 'int64_t' (aka 'long') as the sub-expression, remove this casting [readability-redundant-casting,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4382:30: error: redundant explicit casting to the same type 'int64_t' (aka 'long') as the sub-expression, remove this casting [readability-redundant-casting,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4383:30: error: redundant explicit casting to the same type 'int64_t' (aka 'long') as the sub-expression, remove this casting [readability-redundant-casting,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4406:32: error: use 'contains' to check for membership [readability-container-contains,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4459:61: error: use designated initializer list to initialize 'PairLossFinalRecord' [modernize-use-designated-initializers,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4460:32: error: use designated initializer list to initialize 'PairLossPairKey' [modernize-use-designated-initializers,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4565:26: error: redundant explicit casting to the same type 'int64_t' (aka 'long') as the sub-expression, remove this casting [readability-redundant-casting,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4579:11: error: redundant explicit casting to the same type 'int64_t' (aka 'long') as the sub-expression, remove this casting [readability-redundant-casting,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4614:26: error: redundant explicit casting to the same type 'int64_t' (aka 'long') as the sub-expression, remove this casting [readability-redundant-casting,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4662:26: error: redundant explicit casting to the same type 'int64_t' (aka 'long') as the sub-expression, remove this casting [readability-redundant-casting,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4663:30: error: redundant explicit casting to the same type 'int64_t' (aka 'long') as the sub-expression, remove this casting [readability-redundant-casting,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4664:30: error: redundant explicit casting to the same type 'int64_t' (aka 'long') as the sub-expression, remove this casting [readability-redundant-casting,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4718:28: error: redundant explicit casting to the same type 'int64_t' (aka 'long') as the sub-expression, remove this casting [readability-redundant-casting,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4731:26: error: redundant explicit casting to the same type 'int64_t' (aka 'long') as the sub-expression, remove this casting [readability-redundant-casting,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4742:28: error: redundant explicit casting to the same type 'int64_t' (aka 'long') as the sub-expression, remove this casting [readability-redundant-casting,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:5095:13: error: redundant explicit casting to the same type 'int64_t' (aka 'long') as the sub-expression, remove this casting [readability-redundant-casting,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:5117:17: error: boolean expression can be simplified by DeMorgan's theorem [readability-simplify-boolean-expr,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:5119:32: error: redundant explicit casting to the same type 'int64_t' (aka 'long') as the sub-expression, remove this casting [readability-redundant-casting,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:5134:28: error: redundant explicit casting to the same type 'int64_t' (aka 'long') as the sub-expression, remove this casting [readability-redundant-casting,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:5144:30: error: redundant explicit casting to the same type 'int64_t' (aka 'long') as the sub-expression, remove this casting [readability-redundant-casting,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:5167:45: error: use 'contains' to check for membership [readability-container-contains,-warnings-as-errors]
[0 more errors; see full log]

Full log here.

@romainschotter
romainschotter merged commit d47a767 into AliceO2Group:master Aug 14, 2026
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants