Skip to content

[PWGJE] fix weight and mcphat - #17457

Merged
nzardosh merged 1 commit into
AliceO2Group:masterfrom
joachimckh:mc-weighthat-d1
Aug 15, 2026
Merged

[PWGJE] fix weight and mcphat#17457
nzardosh merged 1 commit into
AliceO2Group:masterfrom
joachimckh:mc-weighthat-d1

Conversation

@joachimckh

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions github-actions Bot added the pwgje label Aug 14, 2026
@github-actions github-actions Bot changed the title [PWJGE] fix weight and mcphat [PWGJE] [PWJGE] fix weight and mcphat Aug 14, 2026
@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 2 disabled

@joachimckh
joachimckh marked this pull request as ready for review August 14, 2026 07:24
@alibuild

alibuild commented Aug 14, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for f3e6638 at 2026-08-14 19:22:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 19 errors and 70 warnings.'
Found 19 errors and 70 warnings.
++ [[ 19 -gt 0 ]]
++ cat /sw/BUILD/a599f66901a3fdde4db56e93d228f9b08726d090/O2Physics-code-check/errors.txt
PWGJE/Tasks/jetSpectraEseTask.cxx:70:8: error: constructor does not initialize these fields: ccdb, pdg [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGJE/Tasks/jetSpectraEseTask.cxx:234:51: error: use designated initializer list to initialize 'EventPlaneFiller' [modernize-use-designated-initializers,-warnings-as-errors]
PWGJE/Tasks/jetSpectraEseTask.cxx:235:52: error: use designated initializer list to initialize 'EventPlaneFiller' [modernize-use-designated-initializers,-warnings-as-errors]
PWGJE/Tasks/jetSpectraEseTask.cxx:236:54: error: use designated initializer list to initialize 'EventPlaneFiller' [modernize-use-designated-initializers,-warnings-as-errors]
PWGJE/Tasks/jetSpectraEseTask.cxx:627:5: error: redundant return statement at the end of a function with a void return type [readability-redundant-control-flow,-warnings-as-errors]
PWGJE/Tasks/jetSpectraEseTask.cxx:631:31: error: the parameter 'track' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGJE/Tasks/jetSpectraEseTask.cxx:645:5: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGJE/Tasks/jetSpectraEseTask.cxx:988:22: error: narrowing conversion from 'unwrap_t<float>' (aka 'float') to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGJE/Tasks/jetSpectraEseTask.cxx:1094:12: error: implicit conversion 'TParticlePDG *' -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGJE/Tasks/jetSpectraEseTask.cxx:1294:12: error: use designated initializer list to initialize 'EventPlane' [modernize-use-designated-initializers,-warnings-as-errors]
PWGJE/Tasks/jetSpectraEseTask.cxx:1351:13: error: member 'secondHarmonic' of type 'const int' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]
PWGJE/Tasks/jetSpectraEseTask.cxx:1353:36: error: the parameter 'collision' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGJE/Tasks/jetSpectraEseTask.cxx:1380:14: error: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr,-warnings-as-errors]
PWGJE/Tasks/jetSpectraEseTask.cxx:1381:5: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGJE/Tasks/jetSpectraEseTask.cxx:1389:14: error: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr,-warnings-as-errors]
PWGJE/Tasks/jetSpectraEseTask.cxx:1390:5: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGJE/Tasks/jetSpectraEseTask.cxx:1441:19: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
PWGJE/Tasks/jetSpectraEseTask.cxx:1451:26: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
PWGJE/Tasks/jetSpectraEseTask.cxx:1524:52: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
++ [[ 70 -gt 0 ]]
++ cat /sw/BUILD/a599f66901a3fdde4db56e93d228f9b08726d090/O2Physics-code-check/warnings.txt
PWGJE/Tasks/jetSpectraEseTask.cxx:643:18: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/jetSpectraEseTask.cxx:645:9: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/jetSpectraEseTask.cxx:662:63: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/jetSpectraEseTask.cxx:668:22: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/jetSpectraEseTask.cxx:674:19: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/jetSpectraEseTask.cxx:679:62: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/jetSpectraEseTask.cxx:691:118: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/jetSpectraEseTask.cxx:720:74: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/jetSpectraEseTask.cxx:722:66: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/jetSpectraEseTask.cxx:725:22: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/jetSpectraEseTask.cxx:736:20: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/jetSpectraEseTask.cxx:746:72: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/jetSpectraEseTask.cxx:748:33: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/jetSpectraEseTask.cxx:777:33: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/jetSpectraEseTask.cxx:779:33: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/jetSpectraEseTask.cxx:781:114: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/jetSpectraEseTask.cxx:783:114: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/jetSpectraEseTask.cxx:786:57: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/jetSpectraEseTask.cxx:788:57: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/jetSpectraEseTask.cxx:793:65: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/jetSpectraEseTask.cxx:796:66: warning: statement should be inside braces [readability-braces-around-statements]
[0 more errors; see full log]

Full log here.

@vkucera vkucera changed the title [PWGJE] [PWJGE] fix weight and mcphat [PWGJE] fix weight and mcphat Aug 14, 2026
@nzardosh
nzardosh enabled auto-merge (squash) August 14, 2026 09:48
@nzardosh

Copy link
Copy Markdown
Collaborator

@joachimckh please consider in your next PR to fix the code-check errors

@nzardosh
nzardosh merged commit 125fee7 into AliceO2Group:master Aug 15, 2026
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants