Skip to content

[PWGDQ] add dimuon analysis in global alignment task - #17416

Merged
mcoquet642 merged 1 commit into
AliceO2Group:masterfrom
aferrero2707:PWGDQ-global-alignment-add-dimuon-analysis
Aug 14, 2026
Merged

[PWGDQ] add dimuon analysis in global alignment task#17416
mcoquet642 merged 1 commit into
AliceO2Group:masterfrom
aferrero2707:PWGDQ-global-alignment-add-dimuon-analysis

Conversation

@aferrero2707

Copy link
Copy Markdown
Contributor

Added comparison of dimuon properties (invariant mass, angles, DCA) for different alignment configurations.

@github-actions

github-actions Bot commented Aug 11, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 61 warnings, 🔕 5 disabled

@aferrero2707
aferrero2707 force-pushed the PWGDQ-global-alignment-add-dimuon-analysis branch from 577fbd8 to 46eb94f Compare August 12, 2026 08:42
@aferrero2707
aferrero2707 marked this pull request as ready for review August 12, 2026 08:49
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 46eb94f at 2026-08-12 14:20:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 27 errors and 3 warnings.'
Found 27 errors and 3 warnings.
++ [[ 27 -gt 0 ]]
++ cat /sw/BUILD/9804978b04b04abc6d19844100ddcabe491c1917/O2Physics-code-check/errors.txt
PWGDQ/Tasks/muonGlobalAlignment.cxx:43:1: error: included header MatchGlobalFwd.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGDQ/Tasks/muonGlobalAlignment.cxx:348:16: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/Tasks/muonGlobalAlignment.cxx:1404:79: error: the parameter 'mftTrackPar' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGDQ/Tasks/muonGlobalAlignment.cxx:1484:15: error: no header providing "ROOT::Math::PxPyPzMVector" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGDQ/Tasks/muonGlobalAlignment.cxx:1490:31: error: no header providing "o2::constants::physics::MassMuon" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGDQ/Tasks/muonGlobalAlignment.cxx:1503:17: error: no header providing "ROOT::Math::XYZVector" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGDQ/Tasks/muonGlobalAlignment.cxx:2146:9: error: function-like macro 'FILL_DIMUON_PLOT' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGDQ/Tasks/muonGlobalAlignment.cxx:2152:63: error: macro argument should be enclosed in parentheses [bugprone-macro-parentheses,-warnings-as-errors]
PWGDQ/Tasks/muonGlobalAlignment.cxx:2152:81: error: macro argument should be enclosed in parentheses [bugprone-macro-parentheses,-warnings-as-errors]
PWGDQ/Tasks/muonGlobalAlignment.cxx:2153:63: error: macro argument should be enclosed in parentheses [bugprone-macro-parentheses,-warnings-as-errors]
PWGDQ/Tasks/muonGlobalAlignment.cxx:2153:81: error: macro argument should be enclosed in parentheses [bugprone-macro-parentheses,-warnings-as-errors]
PWGDQ/Tasks/muonGlobalAlignment.cxx:2157:9: error: function-like macro 'FILL_DIMUON_DCA_PLOTS' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGDQ/Tasks/muonGlobalAlignment.cxx:2162:19: error: macro argument should be enclosed in parentheses [bugprone-macro-parentheses,-warnings-as-errors]
PWGDQ/Tasks/muonGlobalAlignment.cxx:2162:43: error: macro argument should be enclosed in parentheses [bugprone-macro-parentheses,-warnings-as-errors]
PWGDQ/Tasks/muonGlobalAlignment.cxx:2163:19: error: macro argument should be enclosed in parentheses [bugprone-macro-parentheses,-warnings-as-errors]
PWGDQ/Tasks/muonGlobalAlignment.cxx:2163:43: error: macro argument should be enclosed in parentheses [bugprone-macro-parentheses,-warnings-as-errors]
PWGDQ/Tasks/muonGlobalAlignment.cxx:2164:63: error: macro argument should be enclosed in parentheses [bugprone-macro-parentheses,-warnings-as-errors]
PWGDQ/Tasks/muonGlobalAlignment.cxx:2164:81: error: macro argument should be enclosed in parentheses [bugprone-macro-parentheses,-warnings-as-errors]
PWGDQ/Tasks/muonGlobalAlignment.cxx:2165:63: error: macro argument should be enclosed in parentheses [bugprone-macro-parentheses,-warnings-as-errors]
PWGDQ/Tasks/muonGlobalAlignment.cxx:2165:81: error: macro argument should be enclosed in parentheses [bugprone-macro-parentheses,-warnings-as-errors]
PWGDQ/Tasks/muonGlobalAlignment.cxx:2170:9: error: function-like macro 'FILL_DIMUON_ANGLE_PLOT' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGDQ/Tasks/muonGlobalAlignment.cxx:2175:21: error: macro argument should be enclosed in parentheses [bugprone-macro-parentheses,-warnings-as-errors]
PWGDQ/Tasks/muonGlobalAlignment.cxx:2175:32: error: macro argument should be enclosed in parentheses [bugprone-macro-parentheses,-warnings-as-errors]
PWGDQ/Tasks/muonGlobalAlignment.cxx:2176:63: error: macro argument should be enclosed in parentheses [bugprone-macro-parentheses,-warnings-as-errors]
PWGDQ/Tasks/muonGlobalAlignment.cxx:2176:81: error: macro argument should be enclosed in parentheses [bugprone-macro-parentheses,-warnings-as-errors]
PWGDQ/Tasks/muonGlobalAlignment.cxx:2177:63: error: macro argument should be enclosed in parentheses [bugprone-macro-parentheses,-warnings-as-errors]
PWGDQ/Tasks/muonGlobalAlignment.cxx:2177:81: error: macro argument should be enclosed in parentheses [bugprone-macro-parentheses,-warnings-as-errors]
++ [[ 3 -gt 0 ]]
++ cat /sw/BUILD/9804978b04b04abc6d19844100ddcabe491c1917/O2Physics-code-check/warnings.txt
PWGDQ/Tasks/muonGlobalAlignment.cxx:1076:65: warning: statement should be inside braces [readability-braces-around-statements]
PWGDQ/Tasks/muonGlobalAlignment.cxx:1080:47: warning: statement should be inside braces [readability-braces-around-statements]
PWGDQ/Tasks/muonGlobalAlignment.cxx:2203:34: warning: statement should be inside braces [readability-braces-around-statements]
++ [[ 27 -gt 0 ]]
++ exit 1
--

Full log here.

Added comparison of dimuon properties (invariant mass, angles, DCA)
for different alignment configurations.
@aferrero2707
aferrero2707 force-pushed the PWGDQ-global-alignment-add-dimuon-analysis branch from c1fad00 to 986a8a6 Compare August 13, 2026 07:30
@aferrero2707
aferrero2707 marked this pull request as ready for review August 13, 2026 08:30
@alibuild

alibuild commented Aug 13, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 986a8a6 at 2026-08-15 02:56:

## sw/BUILD/O2Physics-latest/log
c++: fatal error: Killed signal terminated program cc1plus
c++: fatal error: Killed signal terminated program cc1plus
c++: fatal error: Killed signal terminated program cc1plus
ninja: build stopped: subcommand failed.

Full log here.

@aferrero2707

Copy link
Copy Markdown
Contributor Author

@iarsene @mcoquet642 @XiaozhiBai @mguilbau this PR is needed quite urgently to analyze the impact of the different alignments on the dimuon invariant mass. Could any of you please have a look?

There are few remaining code-check errors that I need to look in detail:

  • the parameter 'mftTrackPar' is copied for each invocation is a genuine one, but it is harmless. I will fix it in the next PR.
  • do not use static_cast to downcast from a base to a derived class refers to this line, which is also present in other sources. I propose to fix all of them in one single dedicated PR.
  • included header Vector3D.h is not used directly seems to be a false positive, since the header is needed to fix the other error no header providing "ROOT::Math::XYZVector" is directly included
  • same for Vector4D.h and ROOT::Math::PxPyPzMVector

Thanks a lot!

@mcoquet642
mcoquet642 merged commit 90b91dd into AliceO2Group:master Aug 14, 2026
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants