[PWGJE] Adding new Angularity Task to PWGJE - #17299
Conversation
github-actions
Bot
changed the title
|
@Rajdeep-nandi Please follow the contribution guidelines and make sure your PR passes the tests before you open it for review. |
| #include "PWGJE/DataModel/Jet.h" | ||
| #include "PWGJE/DataModel/JetReducedData.h" | ||
| #include "PWGJE/DataModel/JetReducedDataHF.h" | ||
| #include "PWGJE/DataModel/JetSubstructure.h" |
There was a problem hiding this comment.
you seem to have alot of includes which i am not sure are needed?
There was a problem hiding this comment.
When you look at the output of the code-check, you will be sure. ;-)
There was a problem hiding this comment.
Will the code check run if I dont approve? It seems to be waiting for approval
There was a problem hiding this comment.
No it won't, as neither build check would. It requires your approval but also a valid PR that can be merged, which is currently not the case.
Please consider the following formatting changes to AliceO2Group#17299
|
O2 linter results: ❌ 1 errors, |
… issues, remove unused includes, apply clang-format
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
| consteval float getValFromBin(int bin) | ||
| { | ||
| return static_cast<float>(bin) - 0.5f; | ||
| } |
Please consider the following formatting changes to AliceO2Group#17299
|
@nzardosh I have done the o2linter test and clang formatting and tested my code locally and now the o2linter is falling because of some other workflow --Will you please approve for further checks |
|
Dear @Rajdeep-nandi, if this is ready for review now you should change this PR from a draft to ready for review. There should be a button at the bottom that says "Ready for review". |
|
Dear @mhemmer-cern Thank you |
| double energyTot = 0.; | ||
|
|
||
| for (auto const& trk : tracks) { | ||
| const std::array<double, 3> mom{trk.px(), trk.py(), trk.pz()}; |
| momTotal[0] += mom[0]; | ||
| momTotal[1] += mom[1]; | ||
| momTotal[2] += mom[2]; | ||
| energyTot += RecoDecay::e(mom, 0.); // massless approximation for ordinary tracks |
There was a problem hiding this comment.
RecoDecay::e is useless here. E = pc.
5 participants
This Task calculates the Angularity for D0 particles.