Skip to content

[PWGCF] Add multiplicity and transverse momentum fluctuations analysis task - #17019

Draft
orubza wants to merge 20 commits into
AliceO2Group:masterfrom
orubza:omama-analysis
Draft

[PWGCF] Add multiplicity and transverse momentum fluctuations analysis task#17019
orubza wants to merge 20 commits into
AliceO2Group:masterfrom
orubza:omama-analysis

Conversation

@orubza

@orubza orubza commented Jul 11, 2026

Copy link
Copy Markdown

This pull request is for multiplicity and transverse momentum fluctuations analysis task.

The code is tested locally using O2Physics.

@github-actions github-actions Bot added the pwgcf label Jul 11, 2026
@github-actions github-actions Bot changed the title Add multiplicity and transverse momentum fluctuations analysis task [PWGCF] Add multiplicity and transverse momentum fluctuations analysis task Jul 11, 2026
@github-actions

github-actions Bot commented Jul 11, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 1 errors, ⚠️ 0 warnings, 🔕 0 disabled

@vkucera
vkucera marked this pull request as draft July 19, 2026 12:05
@vkucera

vkucera commented Jul 19, 2026

Copy link
Copy Markdown
Collaborator

Hi @orubza , please read the contribution guidelines to get familiar with the development cycle and the steps expected from you. Since you are adding a new file, make sure it is clean from errors and warnings.

@orubza

orubza commented Aug 8, 2026

Copy link
Copy Markdown
Author

Hi @orubza , please read the contribution guidelines to get familiar with the development cycle and the steps expected from you. Since you are adding a new file, make sure it is clean from errors and warnings.

Hi @vkucera I am commiting my code first time. I also checked my errors and I see it is only showing in the CMakeList.txt. Could you please look into it?

@vkucera

vkucera commented Aug 8, 2026

Copy link
Copy Markdown
Collaborator

Hi @orubza , please read the contribution guidelines to get familiar with the development cycle and the steps expected from you. Since you are adding a new file, make sure it is clean from errors and warnings.

Hi @vkucera I am commiting my code first time. I also checked my errors and I see it is only showing in the CMakeList.txt. Could you please look into it?

You still have warnings.

@victor-gonzalez
victor-gonzalez marked this pull request as ready for review August 11, 2026 07:41
@SwatiSaha-1997

Copy link
Copy Markdown
Collaborator

Dear @orubza, could you please update your filename in the CMakeList.txt in the PR?

@SwatiSaha-1997

Copy link
Copy Markdown
Collaborator

Dear @orubza , now that your file name has changed to multandpt-fluctuations
Make the corrsponding Changes in CMakeList.txt file:
o2physics_add_dpl_workflow(multandpt-fluctuations SOURCES multandptFluctuations.cxx PUBLIC_LINK_LIBRARIES O2::Framework O2Physics::AnalysisCore O2Physics::PWGCFCore COMPONENT_NAME Analysis)

@orubza

orubza commented Aug 12, 2026

Copy link
Copy Markdown
Author

Dear @orubza , now that your file name has changed to multandpt-fluctuations Make the corrsponding Changes in CMakeList.txt file: o2physics_add_dpl_workflow(multandpt-fluctuations SOURCES multandptFluctuations.cxx PUBLIC_LINK_LIBRARIES O2::Framework O2Physics::AnalysisCore O2Physics::PWGCFCore COMPONENT_NAME Analysis)

Dear @SwatiSaha-1997 , I have made these changes , but still, it shows that all jobs are failed.

SwatiSaha-1997
SwatiSaha-1997 previously approved these changes Aug 12, 2026
@vkucera
vkucera marked this pull request as draft August 12, 2026 12:12
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for 28186df at 2026-08-12 14:21:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/EbyEFluctuations/Tasks/multandptFluctuations.cxx:139:68: error: 'kNoSameBunchPileup' is not a member of 'o2::aod::evsel'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/EbyEFluctuations/Tasks/multandptFluctuations.cxx:141:74: error: 'kIsGoodZvtxFT0vsPV' is not a member of 'o2::aod::evsel'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/EbyEFluctuations/Tasks/multandptFluctuations.cxx:143:72: error: 'kIsGoodITSLayersAll' is not a member of 'o2::aod::evsel'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/EbyEFluctuations/Tasks/multandptFluctuations.cxx:217:41: error: 'MultandPtFluctuations' was not declared in this scope; did you mean 'MultandptFluctuations'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/EbyEFluctuations/Tasks/multandptFluctuations.cxx:217:63: error: no matching function for call to 'adaptAnalysisTask<<expression error> >(const o2::framework::ConfigContext&)'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/EbyEFluctuations/Tasks/multandptFluctuations.cxx:217:63: error: template argument 1 is invalid
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/EbyEFluctuations/Tasks/multandptFluctuations.cxx:217:69: error: no matching function for call to 'std::vector<o2::framework::DataProcessorSpec>::vector(<brace-enclosed initializer list>)'
ninja: build stopped: subcommand failed.

Full log here.

@vkucera

vkucera commented Aug 12, 2026

Copy link
Copy Markdown
Collaborator

@orubza Your PR does not even compile. You are supposed to test it locally.

@SwatiSaha-1997

SwatiSaha-1997 commented Aug 12, 2026

Copy link
Copy Markdown
Collaborator
Screenshot from 2026-08-12 18-48-14 Dear @orubza, could you please check your PR locally? There are several errors. Please commit only after your code compiles successfully.

@orubza

orubza commented Aug 13, 2026

Copy link
Copy Markdown
Author

Screenshot from 2026-08-12 18-48-14 Dear @orubza, could you please check your PR locally? There are several errors. Please commit only after your code compiles successfully.

Screenshot from 2026-08-13 13-56-00 I have tested the code locally multiple times, and also done a fresh ninja build, and it compiles and runs successfully on my machine. I have attached the screenshot of my ninja build.

@vkucera

vkucera commented Aug 13, 2026

Copy link
Copy Markdown
Collaborator

@orubza

  • Your screenshot shows compilation of an MM tutorial task, not of the code in this PR.
  • Your branch is 417 commits behind the upstream, so you cannot possibly be testing your code with the latest O2Physics.
  • You are adding two files with names differing only in capitalisation. This will break the repository for all macOS users.

Please pay attention to what you do and test your changes properly.

@vkucera vkucera left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking this PR until it gets sane.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

4 participants