docs(sessions): map the current Stop and ownership paths - #6498
Conversation
Trace the Stop path end to end in current code: desktop and mobile entry points, the API cancel branch and every Redis key it touches, the heartbeat that carries the signal, the runner abort, sandbox teardown, records, and interactions. Headline findings, each verified in code: - Stop destroys the warm sandbox (shouldPark refuses an aborted turn). - Stop reaches the runner only on the next 30s heartbeat. - The abort sends no cancel request to the harness except on Pi. - A stopped turn is indistinguishable from a completed one in Postgres. - Cancel leaves pending approvals pending; only kill clears them. - Mobile Stop on the user's own turn never calls the server. - The orphan sweep cannot clear a wedged turn (#6418), because the wedged turn's own heartbeat keeps updated_at fresh. Includes two sequence diagrams, a Redis key table, a file-by-file change map for version one, and the RFC claims the code contradicts. Claude-Session: https://claude.ai/code/session_01GAqSs7fw6QRi2n1ZJ2tmAV
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
mmabrouk
changed the title
📘 Docs preview
This comment updates in place on every push. |
1 participant
Stop currently shares one endpoint and Redis state with attach, cancellation, kill, and approval interruption. This makes behavior difficult to reason about.
This document traces the current browser, API, Redis, heartbeat, runner, harness, sandbox, records, and interaction paths. It includes sequence diagrams, key ownership, time-to-live values, and contradictions between the RFC and current code.
Issue coverage
Research only. It closes no runtime issue. It provides the evidence needed to review the Stop and hung-turn issue group.
Dependencies
Independent documentation on top of the RFC branch.
How to review