Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/bug_report.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ body:
attributes:
value: |
Thanks for taking the time to file this. Please do not report security
vulnerabilities here — use a [private advisory](../../security/advisories/new) instead.
vulnerabilities here. Use a [private advisory](../../security/advisories/new) instead.
- type: textarea
id: what-happened
attributes:
Expand Down
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ Thank you again for your interest in contributing!

- Name tests `{Method}_{Scenario}_{ExpectedResult}`.
- Prefer the purpose-built MSTest assertions (`Assert.HasCount`, `Assert.Contains`,
`Assert.AreSequenceEqual`) over hand-rolled equality checks the analyzers will point you at them.
`Assert.AreSequenceEqual`) over hand-rolled equality checks; the analyzers will point you at them.
- No `Thread.Sleep`. Use `TaskCompletionSource`, channels, or a fake clock.
- New behaviour needs a test. Bug fixes need a test that fails before the fix.

Expand All @@ -124,7 +124,7 @@ fix(webhooks): reject a signature computed over the decoded body
```

Keep the subject under 50 characters and in the imperative mood. Add a body only when the reason for
the change would not be obvious to the next reader — explain *why*, not *what*.
the change would not be obvious to the next reader. Explain *why*, not *what*.

One logical change per commit. Rebase rather than merge when updating a branch.

Expand Down
Loading
Loading