Fix incremental deploy address collision - #146
Merged
Merged
Conversation
After a local wipe, sequential CREATE still lands at the old Hardhat addresses. If localhost.env already mapped AlignmentAttestations to AccountAssertions, fingerprint reuse treated the latter as the former and attestAlignment reverted. Skip reuse when this run already claimed the address.
AdamSpitz
commented
Sep 1, 2026
AdamSpitz
left a comment
AdamSpitz
left a comment
Owner
Author
There was a problem hiding this comment.
Review receipt.
No blocking issues. Same-run claimedBy guard is the correct fix for post-wipe CREATE/env collisions. One cosmetic nit (collision log still uses reuse prefix) not filed as a thread.
Reviewed-with: grok
Reviewed-files: 1
Reviewed-commit: a05ba8d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
localhost.envstill pointedAlignmentAttestationsatAccountAssertions. Fingerprint reuse then treated that bytecode as AlignmentAttestations andattestAlignmentreverted on tiny seed.Test plan
deployments/localhost.env+ manifest,./scripts/stop-wipe-restart.sh --seed --use-hardhat-accountscompleted; AlignmentAttestations is a distinct address from AccountAssertions