Phase execution has no interface seam, so sandbox-bound work can only run in the orchestrator process - #434
Open
AdamFrisby wants to merge 2 commits into
Open
Phase execution has no interface seam, so sandbox-bound work can only run in the orchestrator process#434AdamFrisby wants to merge 2 commits into
AdamFrisby wants to merge 2 commits into
Conversation
Define the phase-execution contract in CodeyBox.Core around a request object (AgentPhaseRequest) instead of an 18-parameter positional list: work item, project, explicit AgentPhaseKind (Work/Rework/Merge, replacing the isInitial bool), repo/branch ids, prompt, runner plus derived agent route, network profile and sandbox flavour, build policy, iteration, pre-emptive-review auditors, rework no-diff handling, resume sha and the no-changes-breaker flag. AgentPhaseResult carries outcome, resulting commit sha (work-branch tip / merge commit), stdout, findings, usage and the captured agent-stream file reference. PipelineRunner takes an optional IAgentPhaseExecutor (default: in-process implementation with exactly the current behaviour) and all five dispatch sites (initial work, preempt-resume rework, merge, post-act rework, audit rework) build requests and call the interface. RunAgentPhaseAsync now also returns the captured stream file name so the result can reference it. Upstream push is untouched: it runs host-side and never enters a sandbox. Tests: request round-trips every carried field; a git-backed executor double drives a full pipeline with a throwing sandbox provider; work, rework and merge parity plus preempt-checkpoint resume run through the interface against the real implementation. CodeyBox-Prompt-Revision: 1 Co-Authored-By: CodeyBox <noreply@codeybox.invalid>
Retry_StaleWorkerHeldItem_FencesAndRetries froze the item 2h ago, which was stale under the old 75m default but no longer is since the audit-budget ordering change raised ItemStaleTimeout to 150m, so the retry correctly 409s. Freeze 3h instead so the fixture is stale under the shipped default; the test's intent is unchanged. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> CodeyBox-Prompt-Revision: 1 Co-Authored-By: CodeyBox <noreply@codeybox.invalid>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated via CodeyBox — work item bb0dc46508f14742a44182921513346b
Initiated by CodeyBox operator
Co-Authored-By: CodeyBox noreply@codeybox.invalid
🤖 Generated with CodeyBox