build: drop the reference-only burn submodule that broke every git-dep consumer #288
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| # Upstream provenance — where the reference tree went | ||
|
|
||
| `crates/burn/upstream` was a git SUBMODULE pointing at | ||
| `https://github.com/AdaWorldAPI/burn.git` (last gitlink | ||
| `9b2b67127b0fbb5387021faf540b7b12b9c4e943` = that repo's merge of PR #4; | ||
| upstream lineage: tracel-ai/burn, `v0.21.0-pre.2`). It was pure reference | ||
| material: `crates/burn/src` reads nothing from it, and `crates/burn` is | ||
| workspace-EXCLUDED besides. | ||
|
|
||
| It is gone because a reference-only submodule taxes EVERY consumer of this | ||
| repo as a git dependency: cargo clones git deps with submodules | ||
| unconditionally, so `medcare-rs`'s Railway build fetched the full burn fork | ||
| just to compile `chacha20` out of this repo — and on 2026-08-31 that fetch | ||
| died on GitHub's unauthenticated shared-IP rate limiting | ||
| ("could not read Username", after three spurious-network retries), taking | ||
| the deploy down. A gitlink is also a commit-pin on an internal sibling — | ||
| the consumer pin law's spirit, one layer down. | ||
|
|
||
| Need the reference tree? Clone the sibling directly: | ||
| `git clone https://github.com/AdaWorldAPI/burn.git` — the fork repo is the | ||
|
Contributor
There was a problem hiding this comment. 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win Check out the recorded commit when retrieving the reference tree. If a reader needs the removed reference tree, the plain Proposed documentation change-`git clone https://github.com/AdaWorldAPI/burn.git` — the fork repo is the
-address; this file is the provenance record (tags over pins, per the
-internal-pin prohibition).
+`git clone https://github.com/AdaWorldAPI/burn.git burn`
+`git -C burn checkout --detach 9b2b67127b0fbb5387021faf540b7b12b9c4e943`
+— the fork repo is the address; this file is the provenance record.🤖 Prompt for AI AgentsSource: MCP tools |
||
| address; this file is the provenance record (tags over pins, per the | ||
| internal-pin prohibition). | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Burn crate still depends on removed submodule
Medium Severity
Most of
crates/burn/srcis still git-symlinked into the deletedcrates/burn/upstreamtree, includinglib.rsand nearly all ops modules. Removing the gitlink leaves those links dangling, so the local SIMD files cannot form a buildable crate. The new provenance note claimssrcreads nothing fromupstream/.Reviewed by Cursor Bugbot for commit a019511. Configure here.