Skip to content

jc: clippy clean on --all-targets, armed in jc-proof.yml (TD-JC-CLIPPY-RED-ON-BASE-1) - #1183

Merged
AdaWorldAPI merged 1 commit into
mainfrom
claude/pr-294-ragged-path-validation-170zcy
Sep 5, 2026
Merged

jc: clippy clean on --all-targets, armed in jc-proof.yml (TD-JC-CLIPPY-RED-ON-BASE-1)#1183
AdaWorldAPI merged 1 commit into
mainfrom
claude/pr-294-ragged-path-validation-170zcy

Conversation

@AdaWorldAPI

Copy link
Copy Markdown
Owner

What

Resolves TD-JC-CLIPPY-RED-ON-BASE-1: crates/jc was red under cargo clippy --manifest-path crates/jc/Cargo.toml --all-targets -- -D warnings on main, and no CI step ran it (the crate is workspace-excluded, so root clippy never reaches it). This PR fixes the 30-odd findings across lib, tests and examples and arms the lint in jc-proof.yml, the same two-step used for sigker in TD-SIGKER-CLIPPY-RED-ON-BASE-1.

Changes (no behaviour change; 141 + 17 tests unchanged)

  • hex seeds regrouped into equal-width digit groups (values identical)
  • doc-comment list indentation (lib.rs, ewa_sandwich, koestenberger, examples); overindented formula continuations fenced as inline code
  • test-only items marked: #[cfg(test)] BinaryTree::stage; PathResult::final_sigma and PlantedGraph descriptor fields allow(dead_code) with reason
  • pearl::classify_three_planes allow(too_many_arguments) (probe harness)
  • weyl::QUINTENZIRKEL literal trimmed to f64 precision
  • type aliases: Pillar (lib.rs), LocusFn (l9 example)
  • probe/example nits: Range::contains, array instead of vec!, clamp, is_multiple_of, merged identical if-arms in the LPA label pick (comments preserved)

CI

jc-proof.yml gains a Lint JC step running the command above.

Board

Gates run locally: append-only OK, citation-decay OK, supersession index regenerated (unchanged).

🤖 Generated with Claude Code

https://claude.ai/code/session_016WkNBjHc2e3zuyz9i8qJEv


Generated by Claude Code

…(TD-JC-CLIPPY-RED-ON-BASE-1)

Lint sweep across crates/jc — no behaviour change, 141 + 17 tests unchanged:
- hex seeds regrouped into equal-width groups (values identical)
- doc-comment list indentation fixed (lib.rs, ewa_sandwich, koestenberger,
  examples); formulas fenced as inline code where continuation lines were
  overindented
- test-only items marked (#[cfg(test)] BinaryTree::stage; PathResult::final_sigma
  and PlantedGraph descriptor fields allowed dead_code with reason)
- pearl::classify_three_planes allowed too_many_arguments (probe harness)
- weyl QUINTENZIRKEL literal trimmed to f64 precision
- lib.rs Pillar type alias; l9 LocusFn alias
- probe/example nits: Range::contains, array not vec!, clamp, is_multiple_of,
  merged identical if-arms in LPA label pick (comments preserved)

CI: jc-proof.yml gains the clippy step so the crate cannot go red unseen again.

Board: #1181 merged-PR row (PR_ARC_INVENTORY + LATEST_STATE), TD status flipped.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016WkNBjHc2e3zuyz9i8qJEv
@coderabbitai

coderabbitai Bot commented Sep 5, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 15 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available. Your 69 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Essentials

Run ID: 0f45d397-6a75-4620-ab9d-240367191610

📥 Commits

Reviewing files that changed from the base of the PR and between 80dbcc3 and 13fdd58.

📒 Files selected for processing (20)
  • .claude/board/LATEST_STATE.md
  • .claude/board/PR_ARC_INVENTORY.md
  • .claude/board/TECH_DEBT.md
  • .github/workflows/jc-proof.yml
  • crates/jc/examples/l9_loci_real_text.rs
  • crates/jc/examples/partof_isa_vs_palette256.rs
  • crates/jc/examples/splat_jaccard_adamic_adar.rs
  • crates/jc/examples/splat_louvain_modularity.rs
  • crates/jc/examples/splat_lpa_label_propagation.rs
  • crates/jc/examples/splat_perturbationslernen.rs
  • crates/jc/src/dueker_zoubouloglou.rs
  • crates/jc/src/ewa_sandwich.rs
  • crates/jc/src/ewa_sandwich_3d.rs
  • crates/jc/src/koestenberger.rs
  • crates/jc/src/lib.rs
  • crates/jc/src/pearl.rs
  • crates/jc/src/pflug.rs
  • crates/jc/src/probe_p1_gamma_phase.rs
  • crates/jc/src/sigma_codebook_probe.rs
  • crates/jc/src/weyl.rs

Comment @coderabbitai help to get the list of available commands.

@cursor

cursor Bot commented Sep 5, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_2cce4001-cff0-4d42-9216-8d4979700e92)

@AdaWorldAPI
AdaWorldAPI marked this pull request as ready for review September 5, 2026 15:34
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@AdaWorldAPI
AdaWorldAPI merged commit cd18228 into main Sep 5, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants