jc: clippy clean on --all-targets, armed in jc-proof.yml (TD-JC-CLIPPY-RED-ON-BASE-1) - #1183
Conversation
…(TD-JC-CLIPPY-RED-ON-BASE-1) Lint sweep across crates/jc — no behaviour change, 141 + 17 tests unchanged: - hex seeds regrouped into equal-width groups (values identical) - doc-comment list indentation fixed (lib.rs, ewa_sandwich, koestenberger, examples); formulas fenced as inline code where continuation lines were overindented - test-only items marked (#[cfg(test)] BinaryTree::stage; PathResult::final_sigma and PlantedGraph descriptor fields allowed dead_code with reason) - pearl::classify_three_planes allowed too_many_arguments (probe harness) - weyl QUINTENZIRKEL literal trimmed to f64 precision - lib.rs Pillar type alias; l9 LocusFn alias - probe/example nits: Range::contains, array not vec!, clamp, is_multiple_of, merged identical if-arms in LPA label pick (comments preserved) CI: jc-proof.yml gains the clippy step so the crate cannot go red unseen again. Board: #1181 merged-PR row (PR_ARC_INVENTORY + LATEST_STATE), TD status flipped. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016WkNBjHc2e3zuyz9i8qJEv
|
Warning Review limit reachedNext included review available in 15 minutes. View limit detailsLimit details: You’ve used the included review currently available. Your 69 included PR review attempts over the past 7 days set your current allowance at 1 review per hour. Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Essentials Run ID: 📒 Files selected for processing (20)
Comment |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_2cce4001-cff0-4d42-9216-8d4979700e92) |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
What
Resolves
TD-JC-CLIPPY-RED-ON-BASE-1:crates/jcwas red undercargo clippy --manifest-path crates/jc/Cargo.toml --all-targets -- -D warningsonmain, and no CI step ran it (the crate is workspace-excluded, so root clippy never reaches it). This PR fixes the 30-odd findings across lib, tests and examples and arms the lint injc-proof.yml, the same two-step used for sigker inTD-SIGKER-CLIPPY-RED-ON-BASE-1.Changes (no behaviour change; 141 + 17 tests unchanged)
#[cfg(test)] BinaryTree::stage;PathResult::final_sigmaandPlantedGraphdescriptor fieldsallow(dead_code)with reasonpearl::classify_three_planesallow(too_many_arguments)(probe harness)weyl::QUINTENZIRKELliteral trimmed to f64 precisionPillar(lib.rs),LocusFn(l9 example)Range::contains, array instead ofvec!,clamp,is_multiple_of, merged identical if-arms in the LPA label pick (comments preserved)CI
jc-proof.ymlgains aLint JCstep running the command above.Board
PR_ARC_INVENTORY+LATEST_STATE: the merged-PR row for planner: seal NestedBands (D-NXG-1/5) and ship the D-BLW-5 shape_rank payload (D-NXG-4) #1181 (NestedBands + D-BLW-5 payload), per the board-hygiene ruleTECH_DEBT: TD-JC-CLIPPY-RED-ON-BASE-1 status → RESOLVEDGates run locally: append-only OK, citation-decay OK, supersession index regenerated (unchanged).
🤖 Generated with Claude Code
https://claude.ai/code/session_016WkNBjHc2e3zuyz9i8qJEv
Generated by Claude Code