Post-merge board hygiene for PR #1144 (D-TEH-3 fate probes) - #1146
Conversation
Mandatory Board-Hygiene Rule: a merged PR needs a LATEST_STATE.md + PR_ARC_INVENTORY.md entry. Adds both for #1144 (30b0a66), including the two corrections that landed during review (i8 fidelity does not clear the gate; the positive-control diagnostic is now committed, not a throwaway script) since the pre-merge LATEST_STATE delta predates those fixes and is append-only. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PFnYKqw6d7TTiB9cT8eFdK
|
Warning Review limit reachedNext included review available in 17 minutes. View limit detailsLimit details: You’ve used the included review currently available. Your 81 included PR review attempts over the past 7 days set your current allowance at 1 review per hour. Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Essentials Run ID: 📒 Files selected for processing (2)
Comment |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_bd1babcc-741e-4288-8350-4e89e18145e8) |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8c0260c0e9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ## 2026-09-03 — MERGED #1144 (`30b0a66`) — D-TEH-3 fate probes: both KILL, semantic_chunker + spiral_segment stay LAB | ||
|
|
||
| - **Added:** `crates/thinking-engine/examples/chunker_falsifier.rs` (real-data falsifier for `semantic_chunker`: 168 cross-topic + 8 same-topic passages, 20 SplitMix64 null permutations, plus a 4th committed positive-control arm — the module's own adversarial synthetic-corners shape — added mid-review so the mechanism-null conclusion is reproducible, not just asserted); `crates/thinking-engine/examples/spiral_gate_probe.rs` (real-data gate probe for `spiral_segment` against five real baked 256x256 tables). Plan `thinking-engine-harvest-closure-v1.md` §4b (pre-registration) + §4c (results); EPIPHANIES `E-TWO-FATE-PROBES-KILL-DIFFERENT-WAYS-1`. | ||
| - **Results:** `semantic_chunker` — recall 0.000 at every pre-registered threshold; the committed positive control also returns zero, confirming a genuine mechanism null rather than a harness artifact. **KILL, stays LAB, not ported to deepnsm-v2.** `spiral_segment` — fidelity clears r/rho >= 0.9980 on every u8 table but NOT on the i8 table (rho tops out at 0.9975 — caught by a Codex review comment on this PR, corrected same-day); compression fails on every table regardless, `ratio_vs_u8 = bytes(u8)/bytes(spiral)` topping out at ~0.28x (i.e. ~3.6x LARGER than the u8 table it would replace), not the module's claimed 51x smaller. **KILL, stays LAB, no certification battery scheduled.** §1c of the closure plan is now fully closed. |
There was a problem hiding this comment.
When this control also returns zero, it fails to show that the measurement apparatus can produce the expected positive result; that outcome remains compatible with the wrong-table or wiring failures explicitly listed in chunker_falsifier.rs:31-43. Consequently, recording the null as genuine and closing §1c can preserve an invalid KILL decision. Require a control that actually fires under this harness, or classify the result as inconclusive rather than ruling out a harness artifact.
Useful? React with 👍 / 👎.
2 participants
Summary
Per the Mandatory Board-Hygiene Rule, a merged PR needs a
LATEST_STATE.md+PR_ARC_INVENTORY.mdentry. #1144 (the D-TEH-3 fate probes —semantic_chunkerandspiral_segmentboth KILL, stay LAB) merged as30b0a66; this adds both entries.Also corrects two things in the pre-merge
LATEST_STATE.mddelta that review changed after it was written (append-only file, so a new entry rather than an edit): thespiral_segmenti8 table does not actually clear the fidelity gate at any tested max_error (Codex caught this), and thesemantic_chunkerpositive-control diagnostic is now a committed, reproducible 4th arm inchunker_falsifier.rsrather than the throwaway script the original delta described (CodeRabbit caught this).Board-hygiene only — no code, no plan changes.
SUPERSESSION-INDEX.mdregenerated and confirmed byte-identical (nothing depends on these two files).🤖 Generated with Claude Code
https://claude.ai/code/session_01PFnYKqw6d7TTiB9cT8eFdK
Generated by Claude Code