fmt: reformat the #1095 probe assertion (workspace fmt was red on main) - #1100
fmt: reformat the #1095 probe assertion (workspace fmt was red on main)#1100AdaWorldAPI wants to merge 1 commit into
Conversation
PR #1095 merged with one rustfmt diff in crates/cognitive-shader-driver/tests/p64_target_identity_probe.rs:73 -- a windows(2).all(...) chain rustfmt wants split across lines. Formatting only; the assertion, its inputs and its meaning are unchanged, and the probe still passes. Scope, measured rather than assumed. Workspace-scoped `cargo fmt --check` was red on exactly ONE file, which is this one. `cargo fmt --all --check` reports 215 diffs, but 214 of those predate #1094/#1095 (verified by re-running the check at 703ac52, the merge-base before both) and all sit in crates/jc, crates/sigker and crates/thinking-engine -- all three workspace-EXCLUDED in Cargo.toml, so CI's fmt gate never reaches them. Those 214 are left untouched: they are a pre-existing condition in excluded crates, not this PR's business, and sweeping them would put ~200 unrelated files in a formatting commit. Verification: cargo fmt --check clean (workspace scope); the probe test passes.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
Included review availability: 0 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 3 reviews per hour. 📝 WalkthroughWalkthroughThe P64 target identity probe reformats one equal-distance assertion into a multiline chained expression. The assertion condition and test behavior remain unchanged. ChangesP64 Target Identity Probe
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This PR only reformats one test assertion without changing its behavior or inputs; the affected test passes and no actionable merge-blocking risk remains. Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
Comment |
2 participants
Superseded by #1101 and closed unmerged.
This PR fixed the one workspace-scoped rustfmt diff #1095 introduced (
crates/cognitive-shader-driver/tests/p64_target_identity_probe.rs:73). #1101 does that and the 214 diffs in the workspace-excludedjc/sigker/thinking-engine, and adds CI gate steps so none of it recurs — so this change is a strict subset of it.The scoping analysis here was superseded too, and corrected in #1101: the 214 were investigated and shown not to be a
1.95.0 → 1.97.1toolchain artefact (rustfmt is 1.9.0 under both; both report the identical 214), so leaving them out was no longer the right call.