fix: lance-graph-ogar OGAR deps switch path -> git (external-consumer resolution) - #1019
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_285cb0ee-0898-43d3-8361-ce67008e4486) |
… resolution) Any external repo pulling lance-graph-ogar via a git dependency fails to resolve OGAR's crates: lance-graph-ogar's path deps escape lance-graph's own repo (../../../OGAR/crates/...), and Cargo's git checkout cache has no OGAR sibling at that relative location regardless of what exists on GitHub or on the builder's disk. This is a hard Cargo constraint on git-sourced crates with escaping path deps, not a missing sibling-checkout step, and it made the crate unconsumable by any external repo whatsoever. Switches ogar-vocab, ogar-class-view, ogar-ontology, ogar-loco, and ogar-adapter-surrealql from path to git deps pinned at AdaWorldAPI/OGAR#main. Verified: cargo check/test green standalone (72+ lib tests incl. the codebook COUNT_FUSE), both this crate's OGAR deps and the existing [patch] section resolve to the identical rev. Accepts the tradeoff the 2026-07-07 "no pins" policy explicitly avoided (a Cargo.lock rev pin) since the alternative is total external unconsumability. symbiont and cognitive-stack carry the same escaping-path shape and are left unfixed here, recorded so it isn't assumed covered.
AdaWorldAPI
force-pushed
the
claude/fix-lance-graph-ogar-git-deps
branch
from
August 24, 2026 07:03
d2ed093 to
cbd57d7
Compare
AdaWorldAPI
changed the title
AdaWorldAPI
pushed a commit
that referenced
this pull request
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
lance-graph-ogar/Cargo.tomldepended on five OGAR crates viapath = "../../../OGAR/crates/..."— an escaping relative path, correct for thissandbox's local multi-repo layout (documented as an explicit "NO PINS —
operator policy 2026-07-07"), but structurally unresolvable once
lance-graph-ogaris consumed as agitdependency by any externalrepo. Cargo clones a git-sourced crate into its own opaque checkout cache
(
~/.cargo/git/checkouts/lance-graph-<hash>/<rev>/); a path escaping thefetched repo resolves relative to that cache directory, which has no
OGAR sibling — nothing ever puts one there, regardless of how fresh
either repo is. This is a hard Cargo constraint, not a missing
sibling-checkout step, and it affects every external consumer of this
crate identically.
Checked and ruled out first: "is OGAR stale?" — no, local
/home/user/OGARmatched
origin/mainexactly,ogar-locohas been onmainsince2026-08-05 (
89d0d3a9).Fix
Switches all five OGAR deps (
ogar-vocab,ogar-class-view,ogar-ontology,ogar-loco,ogar-adapter-surrealql) frompathtogit = "https://github.com/AdaWorldAPI/OGAR", branch = "main".cargo check/cargo testgreen standalone (this crate owns its own[workspace]root) — 72+ lib tests including the codebook COUNT_FUSE.[patch]section'stransitive
lance-graph-contractredirect resolve to the identical rev(
#719471db) — no new contract-source divergence introduced.Tradeoff, accepted explicitly: the 2026-07-07 policy's "always
current sibling, no
Cargo.lockpin" property is gone for this crate — apin is now unavoidable for external consumability. Local/in-sandbox dev
is unaffected (same public GitHub repo, still fetched/cached).
Known residue, not fixed here:
symbiontandcognitive-stackcarrythe identical escaping-path shape (named in the same superseded comment
this PR corrects) and are left untouched —
symbiontis separatelymarked deprecated/operator no-go;
cognitive-stackis unaudited forexternal git-consumers. Recorded in the board entry so a future session
doesn't assume this PR covers them.
Board hygiene
EPIPHANIES.md—E-GIT-SOURCED-CRATE-CANNOT-PATH-DEP-OUTSIDE-ITS-REPO-1.🤖 Generated with Claude Code